Await on redis.subscribe()#62
Open
ifullgaz wants to merge 1 commit intoboringnode:0.xfrom
Open
Conversation
ifullgaz
force-pushed
the
wait-for-redis-subscription
branch
from
f8b1573 to
acef0fc
Compare
ifullgaz
force-pushed
the
wait-for-redis-subscription
branch
from
acef0fc to
b46b21a
Compare
…er Redis has acknowledged the registration of the subscriber. Add return number of subscribers on publish Fix MaxListenersExceededWarning when subscribing to too many channels with Redis transport
ifullgaz
force-pushed
the
wait-for-redis-subscription
branch
from
b46b21a to
a7fd479
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Await on redis.subscribe() to ensure that the method returns only after Redis has acknowledged the registration of the subscriber.
This comes as a resolution to an edge case encountered in such a case:
Server 1 may not have been registered yet as a subscriber and misses the message.