perf(scanner): hoist parser regexps to package level#447
Open
matiasinsaurralde wants to merge 1 commit into
Open
perf(scanner): hoist parser regexps to package level#447matiasinsaurralde wants to merge 1 commit into
matiasinsaurralde wants to merge 1 commit into
Conversation
Compile the five parser path patterns once at package init instead of recompiling them in each parser constructor on every repo scan. BenchmarkNewMemParsers: 9673ns→57ns (169x), 30424B→120B, 255→6 allocs. Signed-off-by: Matías Insaurralde <matias@insaurral.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each repo scan rebuilt the five-parser slice inside its goroutine, running regexp.MustCompile five times per repo. The patterns are static and *regexp.Regexp is concurrency-safe, so this compilation was pure waste — 5·N recompiles for an N-repo org scan.
This hoists the five patterns to package-level vars, compiling them once.