feat: updated to Typescript 6.0#64
Open
dragomirtitian wants to merge 2 commits into
Open
Conversation
dragomirtitian
force-pushed
the
typescript-6.0
branch
from
faf7206 to
e52d72e
Compare
Signed-off-by: Titian Cernicova-Dragomir <tcernicovad1@bloomberg.net>
dragomirtitian
force-pushed
the
typescript-6.0
branch
from
e52d72e to
45e002b
Compare
tchetwin
reviewed
Jun 26, 2026
Comment on lines
18
to
19
| - "18.x" | ||
| - "20.x" |
Collaborator
There was a problem hiding this comment.
We ought to have LTS versions here
Comment on lines
+414
to
+417
| case ts.SyntaxKind.NoSubstitutionTemplateLiteral: | ||
| case ts.SyntaxKind.NumericLiteral: | ||
| case ts.SyntaxKind.PrivateIdentifier: | ||
| case ts.SyntaxKind.BigIntLiteral: |
Collaborator
There was a problem hiding this comment.
What's the context behind this change?
Contributor
Author
There was a problem hiding this comment.
ts.PropertyName now also includes ts.SyntaxKind.NoSubstitutionTemplateLiteral and ts.SyntaxKind.BigIntLiteral. This is invalid syntax, so probably was added for error handling. Added a test to exercise the number literal case, the NoSubstitutionTemplateLiteral does not seem toa actually be produced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to Typescript 6.0