Stabilize tq signal-handling tests#30
Merged
steve-the-edwards merged 2 commits intoblock:mainfrom Apr 22, 2026
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019db0cc-d9b2-76bc-8302-1dc81470607b Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019db0cc-d9b2-76bc-8302-1dc81470607b Co-authored-by: Amp <amp@ampcode.com>
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
tcmulcahy
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tqsignal-handling tests with a shared polling helper that uses bounded linear backoffchild_pidbefore asserting on subprocess cleanupWhy
mainfailed after merging PR Add hierarchical queue capacities #29 in CI run24741062035test (3.12)/72380570655tests/test_tq_cli.py::TestSignalHandling::test_multiple_waiters_cancelled24741092691:tests/test_tq_cli.py::TestSignalHandling::test_sigint_cleanup_running_taskTesting
python -m py_compile tests/test_tq_cli.pyuv run ruff check tests/test_tq_cli.pyuv run pytest -v tests/test_tq_cli.pyReview
amp review "origin/main...HEAD"after the bounded-backoff refactor429rate limit before producing any findings