Migrate remaining k-mer functionalities to Rust#920
Open
padix-key wants to merge 1 commit into
Open
Conversation
Merging this PR will improve performance by 23.99%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | benchmark_score_threshold_rule[11*11*1*1***111] |
1.9 s | 1.2 s | +56.1% |
| ⚡ | benchmark_score_threshold_rule[None] |
2 s | 1.3 s | +56.05% |
| ⚡ | benchmark_kmer_decomposition[11*11*1*1***111] |
171.8 µs | 134 µs | +28.28% |
| ⚡ | benchmark_kmer_decomposition[None] |
122.9 µs | 96.8 µs | +27% |
| ⚡ | benchmark_similar_kmers |
292.8 µs | 240.8 µs | +21.59% |
| ⚡ | benchmark_indexing_from_sequences[11*11*1*1***111-BucketKmerTable(100000)] |
17.3 ms | 14.3 ms | +20.79% |
| ⚡ | benchmark_indexing_from_sequences[11*11*1*1***111-KmerTable] |
18 ms | 15 ms | +19.5% |
| ⚡ | benchmark_indexing_from_sequences[None-BucketKmerTable(100000)] |
7.8 ms | 6.7 ms | +15.39% |
| ⚡ | benchmark_match[BucketKmerTable(10000)-None] |
423.6 µs | 368.2 µs | +15.04% |
| ⚡ | benchmark_indexing_from_sequences[None-KmerTable] |
8.6 ms | 7.5 ms | +14.03% |
| ⚡ | benchmark_match[KmerTable-None] |
333.7 µs | 295 µs | +13.13% |
| ⚡ | benchmark_match_kmer_selection[BucketKmerTable(10000)-None] |
354.3 µs | 320 µs | +10.71% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing padix-key:rust-kmer-misc (2d86546) with main (9e9f6a1)
Footnotes
-
4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
87e1a55 to
64eb8f6
Compare
64eb8f6 to
2d86546
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pursuing #688, this PR migrates the remaining k-mer related functionalities to Rust. This includes
KmerAlphabetKmerSelectorPermutationSimilarityRuleBenchmarks ensured that the new implementations run at least approximately as fast as the legacy Cython implementation.