simple shadow :)#746
Open
spongeis5 wants to merge 3 commits into
Open
Conversation
SquareMan
requested changes
Jun 8, 2026
Member
SquareMan
left a comment
SquareMan
left a comment
There was a problem hiding this comment.
Thanks for this and welcome to the project! I haven't fully reviewed the function code yet as there are some major structural issues introduced by these struct edits you've made. Feel free to ask for more help in the discord if you need it but once this PR passes CI one of us will give it a more thorough review.
Author
|
thank you so much for the feedback !! |
|
| Section | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | .bss |
99.69% | 100.00% | +44 |
| ✅ | .rodata |
14.29% | 100.00% | +13 |
| 📈 | .sdata2 |
50.00% | 77.27% | +13 |
| 📈 | .text |
14.98% | 96.07% | +4093 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | shadowRayEntCB(xEnt*, void*) |
0.00% | 94.18% | +794 |
| 📈 | xShadowSimple_SceneCollide(xShadowSimpleCache*, xVec3*, float) |
0.00% | 97.70% | +484 |
| 📈 | xShadowSimple_CalcCorners(xShadowSimpleCache*, xEnt*, float, float) |
0.00% | 98.35% | +476 |
| 📈 | xShadowSimple_AddVerts(xShadowSimpleCache*) |
0.00% | 89.67% | +326 |
| 📈 | xShadowSimple_Init() |
40.35% | 92.94% | +172 |
| 📈 | xShadowSimple_CacheInit(xShadowSimpleCache*, xEnt*, unsigned char) |
56.84% | 98.75% | +147 |
| 📈 | xShadowSimple_Add(xShadowSimpleCache*, xEnt*, float, float) |
0.00% | 94.52% | +1111 |
| ✅ | xShadowSimpleQueue::operator=(const xShadowSimpleQueue&) |
0.00% | 100.00% | +44 |
| ✅ | xShadowSimple_Render() |
0.00% | 100.00% | +536 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE oh PLEASE review my code i dont wanna screw anything up 😔