Conversation
Dragosh-C
requested review from
bretbrownjr,
changkhothuychung,
dietmarkuehl,
steve-downey and
wusatosi
as code owners
ednolan
left a comment
ednolan
left a comment
There was a problem hiding this comment.
If the project doesn't have examples, don't add empty files just to make the check pass. Either it should have real examples or the beman-tidy check is correct to fail.
Real examples were added - I agree that must be! @ednolan , it seems that main fails to build before this PR - can you help here? |
ednolan
left a comment
ednolan
left a comment
There was a problem hiding this comment.
Please address the clang-format suggestions and rebase this commit onto the latest main (that should remove the failing markdownlint checks).
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| int operator()() const noexcept { return 43; } | ||
| }; | ||
|
|
||
| int main() |
There was a problem hiding this comment.
[pre-commit] reported by reviewdog 🐶
| int main() | |
| int x = f(); |
neatudarius
left a comment
neatudarius
left a comment
There was a problem hiding this comment.
Now tests pass. I will do admin merge.
3 participants
Issue: bemanproject/beman-tidy#253
beman-tidy before:
[error][directory.examples]: The directory 'examples' does not exist. check [Requirement][directory.examples] ... failedbeman-tidy after: