fix(gazelle): handle auto-included __init__.py when generating py_binary targets.#3730
Merged
dougthor42 merged 1 commit intobazel-contrib:mainfrom Apr 23, 2026
Merged
fix(gazelle): handle auto-included __init__.py when generating py_binary targets.#3730dougthor42 merged 1 commit intobazel-contrib:mainfrom
dougthor42 merged 1 commit intobazel-contrib:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Python Gazelle plugin to include __init__.py files in py_binary targets when per_file_generation_mode is active and per_file_include_init is enabled. It refactors the binary target creation to use a builder pattern for conditional source inclusion. Feedback suggests guarding the calculation of the autoIncludeInit flag with a check for per-file generation mode to avoid unnecessary file system operations in package-level generation mode.
dougthor42
reviewed
Apr 23, 2026
dougthor42
reviewed
Apr 23, 2026
Collaborator
dougthor42
left a comment
dougthor42
left a comment
There was a problem hiding this comment.
Oh, and please add a line to CHANGELOG.md
jvolkman
changed the title
dougthor42
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes binary target generation when using per-file mode and automatically
including init.py files.
Fixes #3729