Don't start temp container just to access volume#74
Merged
Conversation
When using a temporary container to get access to the mounted volume, there's no need to actually start a process there. The stopped container is enough.
There was a problem hiding this comment.
Pull request overview
This PR simplifies restore-time volume population by avoiding starting a “temp” container; it relies on a created (but not running) container purely as a mount point for copying data into the application volume.
Changes:
- Remove the
ContainerStartcall for the restore temp container used inpopulateVolume. - Simplify the temp container config to only specify the image (no
sleep infinitycommand).
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a temporary container to get access to the mounted volume, there's no need to actually start a process there. The stopped container is enough.