🐛 (install_app_list): pin fizzy image to :main tag#68
Open
socrabytes wants to merge 1 commit into
Open
Conversation
- Fizzy's CI advances :main (multi-arch) but only moves :latest on v* tags it never publishes - tagless ref resolved to frozen :latest; updater correctly reported "up to date" - fixes TUI picker and once install fizzy CLI alias
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the known app image reference for Fizzy to include an explicit :main tag, and aligns existing UI tests with that new default.
Changes:
- Updated
knownAppsFizzyImageReffrom an untagged image toghcr.io/basecamp/fizzy:main - Adjusted selection/navigation and alias-expansion tests to expect the tagged image reference
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/ui/install_app_list.go | Changes the default image reference for the Fizzy known app to use :main. |
| internal/ui/install_app_list_test.go | Updates assertions to match the new tagged Fizzy image reference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| var knownApps = []KnownApp{ | ||
| {Name: "Campfire", Alias: "campfire", ImageRef: "ghcr.io/basecamp/once-campfire"}, | ||
| {Name: "Fizzy", Alias: "fizzy", ImageRef: "ghcr.io/basecamp/fizzy"}, | ||
| {Name: "Fizzy", Alias: "fizzy", ImageRef: "ghcr.io/basecamp/fizzy:main"}, |
| var knownApps = []KnownApp{ | ||
| {Name: "Campfire", Alias: "campfire", ImageRef: "ghcr.io/basecamp/once-campfire"}, | ||
| {Name: "Fizzy", Alias: "fizzy", ImageRef: "ghcr.io/basecamp/fizzy"}, | ||
| {Name: "Fizzy", Alias: "fizzy", ImageRef: "ghcr.io/basecamp/fizzy:main"}, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins the built-in Fizzy app entry to
ghcr.io/basecamp/fizzy:maininstead of thetagless ref (which resolved to a frozen
:latest). Fizzy's CI only advances:main;:latesthasn't moved in months, so new installs were silently tracking a stale imagewhile the auto-updater correctly reported "up to date."
Changes
ImageRef→ghcr.io/basecamp/fizzy:main(internal/ui/install_app_list.go)TestInstallAppList_NavigateAndSelect,TestExpandAlias)Context
:latestonv*tags, and Fizzy has never cut one(releases use the
fizzy@<sha>scheme). The actively-published, multi-arch tag is:main,which Fizzy's own deployment docs recommend.
and recreate the silent-staleness condition.
:mainand:latestare genuinely different images (verified viadocker manifest inspect):amd64
:main62b174a6…vs:latestf1b641a1…; arm644c46553c…vs6eb940e0….:mainis multi-arch (amd64 + arm64), so no platform handling is needed; the string flowsverbatim to
ImagePull/ImageInspect(no tag normalization touches it).Caveats
Settings.Imageis persisted per-app at install time, so already-deployedFizzy instances keep the stale tag. Recovery:
once update <host> --image ghcr.io/basecamp/fizzy:main.A settings migration is a possible follow-up, out of scope here.
:lateststatus is unverified, sothey're left untouched — worth a separate audit.