Skip to content

[integ-tests-framework] Fix failures from instance type reservation#7468

Merged
hanwen-cluster merged 3 commits into
aws:developfrom
hanwen-cluster:developjul2
Jul 2, 2026
Merged

[integ-tests-framework] Fix failures from instance type reservation#7468
hanwen-cluster merged 3 commits into
aws:developfrom
hanwen-cluster:developjul2

Conversation

@hanwen-cluster

@hanwen-cluster hanwen-cluster commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Description of changes

  • Make resolve_default_instance compatible with tests without instance fixture
  • Skip p series instance types in resolve_default_instance

See commit descriptions for details

Tests

The following tests have passed or skipped as expected:

test-suites:
  efa:
    test_efa.py::test_efa:
      dimensions:
      - instances:
        - p6-b200.48xlarge
        oss:
        - rhel9
        regions:
        - us-east-2
        schedulers:
        - slurm
      - instances:
        - p6-b200.48xlarge
        oss:
        - ubuntu2204
        regions:
        - us-east-2
        schedulers:
        - slurm
      - instances:
        - p6-b200.48xlarge
        oss:
        - rocky8
        regions:
        - us-east-2
        schedulers:
        - slurm
      - instances:
        - p6-b200.48xlarge
        oss:
        - rhel8
        regions:
        - us-east-2
        schedulers:
        - slurm
      - instances:
        - p6-b200.48xlarge
        oss:
        - alinux2023
        regions:
        - us-east-2
        schedulers:
        - slurm
      - instances:
        - p6-b200.48xlarge
        oss:
        - ubuntu2404
        regions:
        - us-east-2
        schedulers:
        - slurm
  networking:
    test_networking.py::test_public_network_topology:
      dimensions:
      - regions:
        - af-south-1
    test_networking.py::test_public_private_network_topology:
      dimensions:
      - regions:
        - af-south-1
  pcluster_api:
    test_api_infrastructure.py::test_api_infrastructure_with_default_parameters:
      dimensions:
      - regions:
        - ap-south-1
    test_api_infrastructure.py::test_api_infrastructure_with_full_parameters:
      dimensions:
      - regions:
        - eu-west-1

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

… tests without instance fixture

`test_api_infrastructure_with_default_parameters` and `test_public_private_network_topology` don't have `instance` specified in `develop.yaml`, therefore the fixture is not available. `architecture` fixture depends on `instance` fixture. This commit delays the usage of `architecture` fixture, and the logic returns gracefully when the fixture doesn't exist
@hanwen-cluster hanwen-cluster requested review from a team as code owners July 2, 2026 15:40
@hanwen-cluster hanwen-cluster added the skip-changelog-update Disables the check that enforces changelog updates in PRs label Jul 2, 2026
@hanwen-cluster hanwen-cluster enabled auto-merge (rebase) July 2, 2026 15:48
@hanwen-cluster hanwen-cluster merged commit f788a14 into aws:develop Jul 2, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog-update Disables the check that enforces changelog updates in PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants