Skip to content

[Test] Fix test_patching_cluster failure by fixing the naming convention for patched AMIs#7466

Merged
gmarciani merged 1 commit into
aws:developfrom
gmarciani:wip/mgiacomo/3160/test-patching-0701-1
Jul 1, 2026
Merged

[Test] Fix test_patching_cluster failure by fixing the naming convention for patched AMIs#7466
gmarciani merged 1 commit into
aws:developfrom
gmarciani:wip/mgiacomo/3160/test-patching-0701-1

Conversation

@gmarciani

@gmarciani gmarciani commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

The prefix keeps the name from matching the pcluster AMI name filter, which is used by the tests to discover base AMI.

Without this change, test_patching_cluster will silently attempt to replace the head node ami with the patched ami when private OS are used, which causes a cluster update failure.

Description of changes

Fix test_patching_cluster failure by fixing the naming convention for patched AMIs

The naming is fixed by adding the prefix "patched-".

The prefix keeps the name from matching the pcluster AMI name filter, which is used by the tests to discover base AMI.

Without this change, test_patching_cluster will silently attempt to replace the head node ami with the patched ami when private OS are used, which causes a cluster update failure.

Tests

  • Fixed the specific error on Rocky8 blocking cluster update
test-suites:
  patching:
    test_patching.py::test_patching_cluster:
      dimensions:
        - regions: [{{ g4dn_8xlarge_CAPACITY_RESERVATION_3_INSTANCES_2_HOURS_NOPG_rocky8 }}]
          instances: ["g4dn.8xlarge"]
          oss: ["rocky8"]
          schedulers: ["slurm"]
        - regions: [{{ g4dn_8xlarge_CAPACITY_RESERVATION_3_INSTANCES_2_HOURS_NOPG_ubuntu2204 }}]
          instances: ["g4dn.8xlarge"]
          oss: ["ubuntu2204"]
          schedulers: ["slurm"]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The prefix keeps the name from matching the pcluster AMI name filter,
which is used by the tests to discover base AMI.

Without this change, test_patching_cluster will silently attempt to replace
the head node ami with the patched ami when private OS are used,
which causes a cluster update failure.
@gmarciani gmarciani requested review from a team as code owners July 1, 2026 17:57
@gmarciani gmarciani added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x Test labels Jul 1, 2026
@gmarciani gmarciani merged commit eed3a5d into aws:develop Jul 1, 2026
27 of 28 checks passed
@gmarciani gmarciani deleted the wip/mgiacomo/3160/test-patching-0701-1 branch July 1, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x skip-changelog-update Disables the check that enforces changelog updates in PRs Test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants