[Release] Add upload-node.py to push aws-parallelcluster-node to S3 #7460
Merged
Conversation
himani2411
added
the
skip-changelog-update
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
added 2 commits
June 30, 2026 12:04
Multi-region S3 uploader for the node package, modeled on upload-cookbook.py. Uploads to s3://<region>-aws-parallelcluster/parallelcluster/<version>/node/, which is where the cookbook now downloads the node package from in all regions (see parallelcluster_node.rb). Invoked by the Jenkins push_node_s3 release job.
Resolves CodeQL py/use-of-exit-or-quit (alerts 2356-2359). exit() is a site.Quitter object that may be absent under python -S or a custom site.py; sys.exit() is always available. Add 'import sys' and convert all four calls.
himani2411
force-pushed
the
cli-devsetting
branch
from
707638c to
ed64496
Compare
added 2 commits
June 30, 2026 12:14
The added-lines CI check (security_exclusions_checker) forbids new nosec/nosemgrep annotations. Replace the suppressed hashlib.md5() with hashlib.md5(usedforsecurity=False), which marks the hash as a checksum (not cryptographic), so scanners no longer flag it and no suppression is needed. Requires Python 3.9+ (repo floor is 3.9).
File.exists? (plural) was removed in Ruby 3.2; the latest AMIs ship Ruby 3.4.9, so the 'Wait for slurmrestd' ruby_block failed with NoMethodError. Switch to the canonical File.exist?, valid on all Ruby versions.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7460 +/- ##
===========================================
+ Coverage 89.91% 89.94% +0.02%
===========================================
Files 180 180
Lines 16200 16253 +53
===========================================
+ Hits 14567 14619 +52
- Misses 1633 1634 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
hehe7318
reviewed
Jun 30, 2026
| _main_region = None | ||
|
|
||
|
|
||
| def _get_all_aws_regions(region): |
Contributor
There was a problem hiding this comment.
Could we extract this method into a common file for use by upload-node.py and upload-cookbook.py?
| return set(sorted(r.get("RegionName") for r in ec2.describe_regions().get("Regions"))) | ||
|
|
||
|
|
||
| def _aws_s3_ls(s3, region, bucket_name, key): |
Contributor
There was a problem hiding this comment.
Same as above, also the below functions.
hanwen-cluster
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This is required as part of our release process as we move from uploading node package from s3 aws/aws-parallelcluster-cookbook#3211
Multi-region S3 uploader for the node package, modeled on upload-cookbook.py. Uploads to s3://-aws-parallelcluster/parallelcluster//node/, which is where the cookbook now downloads the node package from in all regions (see parallelcluster_node.rb). Invoked by the Jenkins push_node_s3 release job.
Tests
References
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.