refactor: remove shouldRun alias and add error isolation in ScheduleManager#115
Merged
Conversation
The cron tool's runJob function passed {} as the sandbox argument to
runScheduledSkill, which expects a callable function. This commit:
1. Add findSkillScript() to locate skill scripts in skill directories
2. Add runScript() to execute scripts via spawn (not fork)
3. Modify runJob() to use runScript when no scheduler module is available
4. Maintain backward compat with existing schedulerModule path
5. Add 7 new tests across findSkillScript, runScript, and cronjob
This allows scheduled cron jobs to execute properly without needing full
scheduler/agent context at runtime.
a10373d to
38971f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove redundant `shouldRun()` alias, clean up unused `_scheduler` parameter from `#clockTick`, and add try/catch error isolation around single-entry clockTick checks. Also updates docs/FLOWS.md to use `matchesCron` consistently.
Type of Change
Testing
All 961 tests pass. Four new test cases added:
Coverage
Checklist