Fix component loading 404 errors on GitHub Pages#9
Merged
Conversation
The `script.js` was using absolute paths (e.g., `/header.html`) to fetch shared components. When the site is hosted on GitHub Pages under a subdirectory defined by a `<base>` tag (e.g., `/static-magic/`), these absolute paths resolved incorrectly to the root of the domain, causing 404 errors and preventing the components from loading. This commit changes the URLs to be relative (e.g., `header.html`). This allows the browser to correctly combine the relative path with the `href` from the `<base>` tag, ensuring that components are fetched from the correct subdirectory.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback. For any comments you don't want me to act on, just include (aside). For security, I will only act on instructions from the user who triggered this task for this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the paths used to fetch shared HTML components (header, nav, footer) to be relative instead of absolute. This fixes 404 errors when the site is hosted in a subdirectory on GitHub Pages, allowing the page to load correctly.
PR created automatically by Jules for task 472309142665937883