Fix: Correct asset and component pathing for GitHub Pages#8
Merged
Conversation
Resolves issues with assets and components not loading on the deployed site. - Renames component files (e.g., `_header.html` to `header.html`) to prevent them from being ignored by Jekyll. - Updates `script.js` to use the new component filenames. - Adds a `<base href="/static-magic/">` tag to all HTML files to ensure that all absolute paths are resolved relative to the site's root in its subdirectory. - Adjusts stylesheet links in `index.html` and `games/index.html` to be compatible with the new base URL.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback. For any comments you don't want me to act on, just include (aside). For security, I will only act on instructions from the user who triggered this task for this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a comprehensive fix for issues related to asset loading on the GitHub Pages site.
The following changes were made:
_header.html,_nav.html, and_footer.htmlto remove the leading underscore, which prevents them from being ignored by the Jekyll build process on GitHub Pages.docs/script.jsto fetch the newly renamed component files.<base href="/static-magic/">tag to the<head>of all HTML pages. This is the key change that makes all root-relative paths (e.g.,/style.css,/header.html) resolve correctly from the site's subdirectory (/static-magic/) instead of the domain root.docs/games/index.htmlanddocs/index.htmlto work correctly with the new<base>tag.These changes ensure that all components, assets (CSS, JS), and internal links will now load correctly across the entire site, including the homepage and all nested sub-pages.
PR created automatically by Jules for task 14995283047609608127