Call getCurrent on mount to drain initial deep link URL#716
Closed
DeepanshuMishraa wants to merge 2 commits into
Closed
Call getCurrent on mount to drain initial deep link URL#716DeepanshuMishraa wants to merge 2 commits into
DeepanshuMishraa wants to merge 2 commits into
Conversation
onOpenUrl only fires for URLs received while the app is already running. When Athas is cold-launched via a CLI command, the URL that launched the app is only available through getCurrent. Without this call, the initial deep link URL is silently dropped and the user sees an empty editor. Fixes athas open ., athas ., athas terminal, athas web, athas remote on cold start.
Member
|
This should be recreated against main since we changed the branch name from master to main :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onOpenUrl only fires for URLs received while the app is already running. When Athas is cold-launched via a CLI command, the URL that launched the app is only available through getCurrent. Without this call, the initial deep link URL is silently dropped and the user sees an empty editor.
Fixes athas open ., athas ., athas terminal, athas web, athas remote on cold start.