[Release] [GitHub Action] Update package versions#484
Conversation
📝 WalkthroughWalkthroughThis PR finalizes synchronized releases across the Asgardeo monorepo by bumping package versions, updating changelogs, and consuming a changeset document. Browser (0.7.2) includes SSR compatibility and module bundling fixes; downstream packages (nuxt, react, vue, nextjs) consume these updates. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/browser/CHANGELOG.md`:
- Around line 11-14: Update the CHANGELOG entry to avoid implying source imports
were modified: replace the phrase about changing directory imports to
'buffer/index.js' with a concise note that the Node.js ESM import resolution was
fixed via the esbuild polyfill/aliasing (the bundler plugin that maps imports
like "buffer/" to "buffer/index.js" and injects the banner/footer), and mention
that source files (e.g., import {Buffer} from 'buffer/'; in
packages/browser/src/web.worker.ts) were left unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 08281cf0-8515-4292-b18e-10f49e2d87cb
📒 Files selected for processing (11)
.changeset/lemon-trams-mix.mdpackages/browser/CHANGELOG.mdpackages/browser/package.jsonpackages/nextjs/CHANGELOG.mdpackages/nextjs/package.jsonpackages/nuxt/CHANGELOG.mdpackages/nuxt/package.jsonpackages/react/CHANGELOG.mdpackages/react/package.jsonpackages/vue/CHANGELOG.mdpackages/vue/package.json
💤 Files with no reviewable changes (1)
- .changeset/lemon-trams-mix.md
| - **Browser:** Fixed Node.js ESM import resolution by changing directory imports (`'buffer/'`) to explicit file paths | ||
| (`'buffer/index.js'`) | ||
| - **Nuxt:** Fixed Rollup bundling by centralizing module augmentations in `module.ts` and removing `.d.ts` file from | ||
| dist |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Verify whether directory-style buffer imports still exist.
rg -nP --type=ts --type=tsx --type=js --type=mjs --type=cjs "from\\s+['\"]buffer/['\"]|require\\(\\s*['\"]buffer/['\"]\\s*\\)"
# Inspect web.worker.ts if present.
fd -i "web.worker.ts" | xargs -r -I{} sh -c "echo '--- {}'; nl -ba {} | sed -n '1,60p'"
# Expected result:
# - If matches exist, changelog wording should be narrowed or source imports should be updated.
# - If no matches, this comment can be dismissed.Repository: asgardeo/javascript
Length of output: 91
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Verify whether directory-style buffer imports still exist (corrected flags)
echo "=== Searching for buffer/ directory imports ==="
rg -nP "from\s+['\"]buffer/['\"]|require\(\s*['\"]buffer/['\"]" --type ts --type js
echo -e "\n=== Looking for web.worker.ts ==="
fd "web.worker.ts" -exec cat -n {} \;
echo -e "\n=== Checking CHANGELOG.md context ==="
fd "CHANGELOG.md" packages/browser -exec sed -n '1,20p' {} \;Repository: asgardeo/javascript
Length of output: 465
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== All buffer import occurrences ==="
rg "from\s+['\"]buffer" packages/browser/src/ -A 1 -B 1
echo -e "\n=== Checking web.worker.ts full content ==="
cat packages/browser/src/web.worker.ts
echo -e "\n=== CHANGELOG.md full entry (lines 11-14) ==="
sed -n '11,14p' packages/browser/CHANGELOG.md
echo -e "\n=== Check if there are bundle/rollup config files ==="
fd -e "rollup" -e "webpack" -e "tsconfig" -e "build" packages/browserRepository: asgardeo/javascript
Length of output: 3097
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== Search for 'buffer/index.js' imports (claimed in changelog) ==="
rg "buffer/index\.js" packages/browser/ || echo "No matches found"
echo -e "\n=== Looking for build/bundler config files ==="
fd . packages/browser --type f | grep -E "(esbuild|rollup|webpack|tsconfig|build)" | head -20
echo -e "\n=== Check build or config files in packages/browser root ==="
ls -la packages/browser/ | grep -E "\.(ts|js|json|config)" || echo "No config files in root"
echo -e "\n=== Searching for esbuild configuration ==="
fd -e "ts" -e "js" -e "json" . packages/browser --type f | xargs rg -l "esbuild|Buffer" | head -10Repository: asgardeo/javascript
Length of output: 1547
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== Examine esbuild.config.mjs ==="
cat packages/browser/esbuild.config.mjs
echo -e "\n=== Verify no buffer/index.js in source files ==="
rg "buffer/index\.js" packages/browser/src/ || echo "Confirmed: No buffer/index.js in source code"Repository: asgardeo/javascript
Length of output: 3024
Changelog entry overstates the scope of the import fix.
The changelog claims directory imports were changed to explicit 'buffer/index.js' paths, but source code still contains import {Buffer} from 'buffer/'; in packages/browser/src/web.worker.ts. The actual fix is at the bundler level only (esbuild plugin aliasing buffer to 'buffer/index.js' and banner/footer setup), not source code. Update the changelog to clarify: "Fixed Node.js ESM import resolution via esbuild polyfill plugin" or similar, rather than implying source imports were changed.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/browser/CHANGELOG.md` around lines 11 - 14, Update the CHANGELOG
entry to avoid implying source imports were modified: replace the phrase about
changing directory imports to 'buffer/index.js' with a concise note that the
Node.js ESM import resolution was fixed via the esbuild polyfill/aliasing (the
bundler plugin that maps imports like "buffer/" to "buffer/index.js" and injects
the banner/footer), and mention that source files (e.g., import {Buffer} from
'buffer/'; in packages/browser/src/web.worker.ts) were left unchanged.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@asgardeo/browser@0.7.2
Patch Changes
#483
519fa74Thanks@kavindadimuthu! - Fix SSR compatibility and module bundling issues
'buffer/') to explicit file paths(
'buffer/index.js')module.tsand removing.d.tsfile fromdist
@asgardeo/nextjs@0.3.14
Patch Changes
@asgardeo/nuxt@0.1.2
Patch Changes
#483
519fa74Thanks@kavindadimuthu! - Fix SSR compatibility and module bundling issues
'buffer/') to explicit file paths(
'buffer/index.js')module.tsand removing.d.tsfile fromdist
Updated dependencies
[
519fa74]:@asgardeo/react@0.23.3
Patch Changes
[
519fa74]:@asgardeo/vue@0.3.5
Patch Changes
[
519fa74]:Summary by CodeRabbit
Bug Fixes
Chores