chore(deps-dev): bump eslint from 8.57.1 to 10.3.0 in /apps/desktop#131
chore(deps-dev): bump eslint from 8.57.1 to 10.3.0 in /apps/desktop#131dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
1fe391e to
f437c28
Compare
f437c28 to
39d7efd
Compare
39d7efd to
815da52
Compare
815da52 to
505a864
Compare
|
PR author is in the excluded authors list. |
| "electron": "^40.2.1", | ||
| "electron-builder": "^26.8.1", | ||
| "eslint": "^8.57.1", | ||
| "eslint": "^10.2.0", |
There was a problem hiding this comment.
[🟡 Medium] [🔵 Bug]
ESLint is bumped from 8.57.1 to 10.2.0, but all three ESLint plugins in this project declare peer dependency ranges that exclude ESLint 10:
@typescript-eslint/eslint-plugin@6.21.0→"eslint": "^7.0.0 || ^8.0.0"@typescript-eslint/parser@6.21.0→"eslint": "^7.0.0 || ^8.0.0"eslint-plugin-react-hooks@7.0.1→"eslint": "^3.0.0 || ... || ^9.0.0"(no^10)
// apps/desktop/package.json
"@typescript-eslint/eslint-plugin": "^6.21.0",
"@typescript-eslint/parser": "^6.21.0",
"eslint": "^10.2.0",
"eslint-plugin-react-hooks": "^7.0.1",npm install with --legacy-peer-deps or loose settings may succeed, but the plugins are untested against ESLint 10's internal API changes (new eslint-scope@9, espree@11, eslint-visitor-keys@5). This can produce silent lint misses, false positives, or outright crashes at lint time. Either keep ESLint on v8/v9 until all plugins declare ESLint 10 support, or upgrade @typescript-eslint/* to v8+ (which supports ESLint 9/10) and eslint-plugin-react-hooks to a version with ^10 in its peer range.
505a864 to
55bc23d
Compare
| "electron": "^40.2.1", | ||
| "electron-builder": "^26.8.1", | ||
| "eslint": "^8.57.1", | ||
| "eslint": "^10.2.1", |
There was a problem hiding this comment.
[🟡 Medium] [🔵 Bug]
ESLint is bumped from 8.57.1 to 10.2.1, but all three ESLint plugins in this project declare peer dependency ranges that exclude ESLint 10:
@typescript-eslint/eslint-plugin@6.21.0→"eslint": "^7.0.0 || ^8.0.0"@typescript-eslint/parser@6.21.0→"eslint": "^7.0.0 || ^8.0.0"eslint-plugin-react-hooks@7.0.1→"eslint": "^3.0.0 || ... || ^9.0.0"(no^10)
All three are actively imported in eslint.config.mjs. ESLint 10's internals changed substantially (eslint-scope v7→v9, espree v9→v11, eslint-visitor-keys v3→v5), so the @typescript-eslint v6 plugins — which depend on the old internal APIs — will likely crash or silently misbehave at lint time. Either keep ESLint on v8/v9 until all plugins declare ESLint 10 support, or upgrade @typescript-eslint/* to v8+ (supports ESLint 9/10) and eslint-plugin-react-hooks to a version with ^10 in its peer range.
// apps/desktop/package.json
"@typescript-eslint/eslint-plugin": "^6.21.0",
"@typescript-eslint/parser": "^6.21.0",
"eslint": "^10.2.1",
"eslint-plugin-react-hooks": "^7.0.1",55bc23d to
621b233
Compare
621b233 to
42c7870
Compare
|
Deployment failed with the following error: Learn More: https://vercel.com/arul28s-projects?upgradeToPro=build-rate-limit |
| "electron": "^40.2.1", | ||
| "electron-builder": "^26.8.1", | ||
| "eslint": "^8.57.1", | ||
| "eslint": "^10.2.1", |
There was a problem hiding this comment.
[🔴 Critical] [🔵 Bug]
@typescript-eslint/eslint-plugin@6.21.0 and @typescript-eslint/parser@6.21.0 both declare "eslint": "^7.0.0 || ^8.0.0" as a peer dependency. This bump to ESLint 10 violates that constraint — npm install will emit peer dependency warnings/errors (or fail with --strict-peer-deps), and the plugin will likely crash at runtime when the internal ESLint APIs it relies on (e.g., eslint-scope@7, eslint-visitor-keys@3, the Linter class shape) no longer exist. The npm run lint command from the AGENTS.md validation checks will break. To fix, either keep ESLint at ^8.57.1 or simultaneously upgrade to @typescript-eslint v8+ (which supports ESLint 9/10) and eslint-plugin-react-hooks v5+ (which supports ESLint 9+). Skipping ESLint v9 entirely with a jump to v10 is feasible but all plugin dependencies must be coordinated.
// apps/desktop/package-lock.json — @typescript-eslint/eslint-plugin@6.21.0
"peerDependencies": {
"@typescript-eslint/parser": "^6.0.0 || ^6.0.0-alpha",
"eslint": "^7.0.0 || ^8.0.0"
}[🟠 High] [🔵 Bug]
eslint-plugin-react-hooks@7.0.1 declares "eslint": "^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0-0 || ^9.0.0" as a peer dependency. ESLint 10 is not covered by this range, so npm install will report a peer dependency conflict and the plugin may fail at runtime with ESLint 10's changed internals. This needs to be coordinated with the eslint upgrade — either pin eslint back to a supported version or upgrade eslint-plugin-react-hooks to a version that supports ESLint 10.
// apps/desktop/package-lock.json — eslint-plugin-react-hooks@7.0.1
"peerDependencies": {
"eslint": "^3.0.0 || ... || ^9.0.0"
}79acb22 to
c7c89f6
Compare
c7c89f6 to
32e167d
Compare
|
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting |
18449de to
81897a6
Compare
Bumps [eslint](https://github.com/eslint/eslint) from 8.57.1 to 10.3.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v8.57.1...v10.3.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 10.2.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
81897a6 to
928b9b1
Compare
|
Superseded by #235. |
Bumps eslint from 8.57.1 to 10.3.0.
Release notes
Sourced from eslint's releases.
... (truncated)
Commits
788920410.3.05b69b4fBuild: changelog update for 10.3.0d32235eci: use pnpm ineslint-flat-config-utilstype integration test (#20826)b6ae5cffix: handle unavailable require cache (#20812)3ffb14echore: clean up typos in comments and JSDoc (#20821)6fb3685fix: rule suggestions cause continuation in class body (#20787)22eb58achore: add missing continue-on-error to ecosystem-tests.yml (#20818)88bf002ci: bump pnpm/action-setup from 6.0.1 to 6.0.3 (#20815)379571afeat: add suggestions for no-unused-private-class-members (#20773)97c8c33chore: update ilshidur/action-discord action to v0.4.0 (#20811)