cosmetic: clean up build warnings (locale, setfont, GPG, oras)

[igorpecovnik]

Summary

Silences five categories of noisy but harmless warnings that clutter every image build log. Two commits, 4 files, +46 / -7 lines.

Commit 1: chroot environment cleanup

warning	cause	fix
`bash: warning: setlocale: LC_ALL: cannot change locale (sl_SI.UTF-8)`	Host's `LC_ALL` leaks into chroot via `chroot_sdcard`	Set `LC_ALL=C LANG=C LANGUAGE="" SUDO_USER=""` in wrappers + direct `chroot` calls
`gpg: WARNING: unsafe ownership on homedir`	`gpg --dearmor` under sudo uses builder's `~/.gnupg`	Temporary `--homedir` for the single dearmor call
`setfont: ERROR kdfontop.c:29 is_kd_text: ioctl(KDGETMODE)`	`setupcon --save --force` triggers setfont in chroot (no tty)	Redirect stderr to `/dev/null`
`W: Download is performed unsandboxed as root`	`_apt` user doesn't exist in fresh rootfs	Pre-create `/etc/apt/apt.conf.d/99-armbian-sandbox` before mmdebstrap; removed in cleanup
`id: 'igorp': no such user`	`SUDO_USER` leaks from host into chroot	Cleared in the same wrapper fix

Files: `lib/functions/logging/runners.sh`, `lib/functions/rootfs/distro-specific.sh`, `lib/functions/rootfs/rootfs-create.sh`

Commit 2: oras 404 cosmetic

warning	cause	fix
`Error response from registry: failed to fetch`	oras manifest probe returns 404 on cache miss (normal)	Capture stderr; suppress if "not found"; show as warning for any other error

File: `lib/functions/general/oci-oras.sh`

Test plan

• Build a desktop image — all five warning categories gone from the log
• Locale generation still works (`en_US.UTF-8` generated correctly)
• Console font config saved correctly in `/etc/default/console-setup`
• Armbian GPG key correctly dearmored in `/usr/share/keyrings/`
• `99-armbian-sandbox` file absent from the final image (`/etc/apt/apt.conf.d/`)
• Cache miss shows single clean `[🌱] Artifact is not available in remote cache` line
• Real oras errors (auth, network) still shown as `[⚠]` warning
• No regression on arm64 cross-builds (qemu chroot with `LC_ALL=C`)

Summary by CodeRabbit

• Bug Fixes

  • Prevented host locale and username from leaking into build chroots to avoid inconsistent package behavior and accidental host references.
  • Suppressed noisy console-setup errors during root filesystem creation to reduce misleading build output.
  • Improved external artifact fetch handling by capturing stderr and emitting clearer warnings on unexpected errors.

• Chores

  • Isolated GPG operations to a temporary home to avoid using the builder's keyring.
  • Applied apt sandbox config only during build and removed it from the final filesystem.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d47ab17f-9c3e-4255-91e6-d19bf747d6e6

📥 Commits

Reviewing files that changed from the base of the PR and between 8081847 and 06bdf1b.

📒 Files selected for processing (4)

• lib/functions/general/oci-oras.sh
• lib/functions/logging/runners.sh
• lib/functions/rootfs/distro-specific.sh
• lib/functions/rootfs/rootfs-create.sh

✅ Files skipped from review due to trivial changes (1)

• lib/functions/rootfs/distro-specific.sh

🚧 Files skipped from review as they are similar to previous changes (3)

• lib/functions/general/oci-oras.sh
• lib/functions/logging/runners.sh
• lib/functions/rootfs/rootfs-create.sh

---

📝 Walkthrough

Walkthrough

Chroot-invoked commands now run with neutralized locale environment variables (LC_ALL="C", LANG="C", LANGUAGE="") and SUDO_USER cleared; Armbian GPG dearmor/import uses a temporary GNUPGHOME removed after use; an APT sandbox drop-in is added before mmdebstrap and removed after; setupcon failures are suppressed.

Changes

Cohort / File(s)	Summary
Chroot environment & runners lib/functions/logging/runners.sh	chroot_sdcard() and chroot_mount() now call run_host_command_logged_raw with LC_ALL="C" LANG="C" LANGUAGE="" injected; SUDO_USER is cleared for chroot invocations.
Distro-specific GPG / chroot calls lib/functions/rootfs/distro-specific.sh	GPG dearmor/import uses a temporary GNUPGHOME (via mktemp -d --homedir) and removes it afterward; chrooted keyring/apt-key steps are prefixed with forced locale env and empty SUDO_USER.
Rootfs creation / mmdebstrap adjustments lib/functions/rootfs/rootfs-create.sh	Pre-creates etc/apt/apt.conf.d/99-armbian-sandbox in target (sets APT::Sandbox::User "root") before mmdebstrap and removes it after; setupcon --save --force inside chroot redirects stderr to /dev/null and uses `
OCI/ORAS manifest handling lib/functions/general/oci-oras.sh	oras manifest fetch stderr is captured to a temp file; when no manifest and stderr is non-empty and not a "not found" message, a warning is emitted; parsing runs only when manifest exists.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 I hopped into chroots calm and free,
LANG set to C, no locale spree.
A temp GPG burrow, tidied tight,
apt sandbox placed by lantern light.
setupcon sighs — the build stays bright.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the PR's main objective: silencing multiple cosmetic build warnings across four subsystems (locale, setfont, GPG, and oras).
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-chroot-locale-warnings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

lib/functions/rootfs/distro-specific.sh (1)

269-275: Use trap-based cleanup for temporary GPG homedir.

If gpg --dearmor fails, rm -rf "${gpg_tmp}" won’t run and temp dirs accumulate. Prefer a trap to guarantee cleanup.

Suggested patch

 	local gpg_tmp
 	gpg_tmp=$(mktemp -d)
+	trap 'rm -rf "${gpg_tmp}"' RETURN
 	gpg --homedir "${gpg_tmp}" --batch --yes --dearmor < "${SRC}"/config/armbian.key > "${basedir}${APT_SIGNING_KEY_FILE}"
-	rm -rf "${gpg_tmp}"
+	trap - RETURN
+	rm -rf "${gpg_tmp}"

Based on learnings scripts in this framework run with set -e, so failure paths should still guarantee cleanup.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@lib/functions/rootfs/distro-specific.sh` around lines 269 - 275, The
temporary GPG homedir created with gpg_tmp=$(mktemp -d) can leak if gpg
--dearmor fails; set a trap immediately after creating gpg_tmp to always remove
it (e.g., trap 'rm -rf "${gpg_tmp}"' EXIT), then run gpg --homedir "${gpg_tmp}"
--batch --yes --dearmor < "${SRC}"/config/armbian.key >
"${basedir}${APT_SIGNING_KEY_FILE}"; after successful use you may optionally
clear the trap (trap - EXIT) or leave it to run on EXIT; reference gpg_tmp,
mktemp -d, gpg --homedir ... --dearmor and rm -rf "${gpg_tmp}" to locate where
to add the trap.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@lib/functions/rootfs/distro-specific.sh`:
- Line 282: The two direct chroot invocations that currently prefix LC_ALL=C
LANG=C should also clear LANGUAGE and SUDO_USER to avoid leaking locale and sudo
user info; update both commands (the one creating the symlink to
armbian-archive-keyring.gpg and the other at the later occurrence) to prefix
with LC_ALL=C LANG=C LANGUAGE= SUDO_USER= before chroot so the environment
becomes: LC_ALL=C LANG=C LANGUAGE= SUDO_USER= chroot "${basedir}" /bin/bash -c
"…".

---

Nitpick comments:
In `@lib/functions/rootfs/distro-specific.sh`:
- Around line 269-275: The temporary GPG homedir created with gpg_tmp=$(mktemp
-d) can leak if gpg --dearmor fails; set a trap immediately after creating
gpg_tmp to always remove it (e.g., trap 'rm -rf "${gpg_tmp}"' EXIT), then run
gpg --homedir "${gpg_tmp}" --batch --yes --dearmor < "${SRC}"/config/armbian.key
> "${basedir}${APT_SIGNING_KEY_FILE}"; after successful use you may optionally
clear the trap (trap - EXIT) or leave it to run on EXIT; reference gpg_tmp,
mktemp -d, gpg --homedir ... --dearmor and rm -rf "${gpg_tmp}" to locate where
to add the trap.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6d387a8e-4a27-49ca-a40b-48fd4560d18f

📥 Commits

Reviewing files that changed from the base of the PR and between 8fb6c51 and f9faa5d.

📒 Files selected for processing (3)

• lib/functions/logging/runners.sh
• lib/functions/rootfs/distro-specific.sh
• lib/functions/rootfs/rootfs-create.sh