Make NdPluginAttribute compression aware, add unit tests for NDPluginAttribute#583
Open
jwlodek wants to merge 2 commits intoareaDetector:masterfrom
Open
Make NdPluginAttribute compression aware, add unit tests for NDPluginAttribute#583jwlodek wants to merge 2 commits intoareaDetector:masterfrom
jwlodek wants to merge 2 commits intoareaDetector:masterfrom
Conversation
gustavosr8
reviewed
Apr 30, 2026
| /* Test that NDPluginAttribute reads attributes from an uncompressed array */ | ||
| BOOST_AUTO_TEST_CASE(test_attribute_uncompressed) | ||
| { | ||
| NDArray *input = createTestArray(); |
Member
There was a problem hiding this comment.
Since you are using in the other tests, missing BOOST_REQUIRE(input != NULL)
| processArray(input); | ||
|
|
||
| double readVal = attr->readDouble(NDPluginAttributeValString, 0); | ||
| BOOST_CHECK_CLOSE(readVal, 42.5, 0.001); |
Member
There was a problem hiding this comment.
Suggested change
| BOOST_CHECK_CLOSE(readVal, 42.5, 0.001); | |
| BOOST_CHECK_CLOSE(readVal, testVal, 0.001); |
| processArray(input); | ||
|
|
||
| double readVal = attr->readDouble(NDPluginAttributeValString, 0); | ||
| BOOST_CHECK_CLOSE(readVal, 99.0, 0.001); |
Member
There was a problem hiding this comment.
Suggested change
| BOOST_CHECK_CLOSE(readVal, 99.0, 0.001); | |
| BOOST_CHECK_CLOSE(readVal, testVal, 0.001); |
| processArray(input); | ||
|
|
||
| double readVal = attr->readDouble(NDPluginAttributeValString, 0); | ||
| BOOST_CHECK_CLOSE(readVal, 12345.0, 0.001); |
Member
Author
There was a problem hiding this comment.
I think CHECK_EQUAL should be OK. I usually use CHECK_CLOSE or the framework equivalent for floats due to precision issues, but since we're not doing any calculations or the like here it should match exactly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #582. Was as simple as adding the boolean flag to the end of the superclass constructor call. Also added unit tests for the plugin that test with compressed and uncompressed arrays.