ci: detect drift between committed and generated FFI bindings#66
Merged
Merged
Conversation
pfeifferj
force-pushed
the
ci/check-bindings-drift
branch
from
eb1b649 to
0298ac2
Compare
pfeifferj
force-pushed
the
ci/check-bindings-drift
branch
15 times, most recently
from
fc84cdc to
91bf785
Compare
The pre-generated ffi.rs and ffi_git.rs files can silently diverge from what bindgen produces if someone updates libalpm headers without regenerating. Add a diff check after the test step in both CI jobs to catch this. Signed-off-by: Josephine Pfeiffer <hi@josie.lol>
pfeifferj
force-pushed
the
ci/check-bindings-drift
branch
from
91bf785 to
e31c638
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pre-generated ffi.rs and ffi_git.rs files can silently diverge from what bindgen produces if someone updates libalpm headers without regenerating. Add a diff check after the test step in both CI jobs to catch this.
Related: #67