You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 5, 2022. It is now read-only.
I found the nginx tmpl you supply couldnt handle muilti location in one server.
the new tmpl solved the problem however it use VIRTUAL_PATH env
hope to fix it later
I'm not going to merge this PR in its current form. I think it's important that the upstream nginx.tmpl start using define blocks for common chunks of configuration, so I don't like that those were removed. Besides that, it makes it difficult for me to review what you've actually changed here.
In addition, since @jwilder wants to support this functionality by extending the syntax of the VIRTUAL_HOST variable instead of using a separate VIRTUAL_PATH variable (as discussed in nginx-proxy#254), I'm not keen to spend much time on this branch.
If I do get any time to work on supporting multiple paths in the nginx-proxy image, that time will be spent creating a usable library from docker-gen so that we can use a custom nginx-proxy binary written in Go that can streamline a lot of the nasty template logic in nginx.tmpl. See my (not working) generator branch of docker-gen for where I left off with that work.
actually the tpl is comes from another authoer, because it really works, so i think maybe its helpful to the branch, just the branch.
nice
i use traefik for a time, which combine path with host with mux, the regexp follows the host confuse me a lot, which doesnt support ^ \b .etc, the tpl in muiltipath branch has the same problem, so is there any question combing the path & host?
anyway im look forward the new version of nginx-proxy, its amazing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found the nginx tmpl you supply couldnt handle muilti location in one server.
the new tmpl solved the problem however it use VIRTUAL_PATH env
hope to fix it later