Move the VminitdCore library to the top-level package#742
Conversation
| path: "vminitd/Sources/LCShim" | ||
| ), | ||
| .target( | ||
| name: "Cgroup", |
There was a problem hiding this comment.
I'm not super happy about this as I wanted to give the API we expose a better exploration, but if this is what we need to do for now that's okay with me.
There was a problem hiding this comment.
Agreed, we can trim what doesn't need to cross the package boundary.
There was a problem hiding this comment.
I more meant if we could get away with not making Cgroup public as I haven't given a great deal of thought to the API outside of our immediate needs for it
There was a problem hiding this comment.
To be honest, I'd prefer if we had a ContainerizationCgroup target in the root of the repo if we are going to public-ify it.
There was a problem hiding this comment.
Moved the container cgroup setup from vmexec to vminitd.
2 participants
External Swift Package Manager consumers can only see products declared in the top-level
Package.swift. TheVminitdCorelibrary was declared inside thevminitdsubpackage, so it was impossible to build a customvminitdagainst it via a URL dependency oncontainerization. This change moves theVminitdCoreto the top-levelPackage.swift.