Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/crawlee/storage_clients/_redis/_dataset_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,8 @@ async def get_data(
match (desc, offset, limit):
case (True, 0, int()):
json_path += f'[-{limit}:]'
case (True, 0, None):
json_path += '[:]'
case (True, int(), None):
json_path += f'[:-{offset}]'
case (True, int(), int()):
Expand Down
11 changes: 11 additions & 0 deletions tests/unit/storages/test_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,17 @@ async def test_get_data_descending_order(dataset: Dataset) -> None:
assert result.items[-1]['id'] == 1


async def test_get_data_descending_with_unlimited_limit(dataset: Dataset) -> None:
"""Test that get_data with desc=True and limit=None returns all items in reverse order."""
items = [{'id': i} for i in range(1, 4)] # 3 items
await dataset.push_data(items)

result = await dataset.get_data(desc=True, limit=None)

assert result.count == 3
assert result.items == [{'id': 3}, {'id': 2}, {'id': 1}]


async def test_get_data_skip_empty(dataset: Dataset) -> None:
"""Test getting data with skip_empty option filters out empty items."""
# Add some items including an empty one
Expand Down
Loading