Skip to content

fix(memory-storage): Apply skip_empty after pagination in MemoryDatasetClient.get_data #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vdusek wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

fix(memory-storage): Apply skip_empty after pagination in MemoryDatasetClient.get_data #1937

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/crawlee/storage_clients/_memory/_dataset_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,17 +171,17 @@ async def get_data(
total = len(self._records)
items = self._records.copy()

# Apply skip_empty filter if requested
if skip_empty:
items = [item for item in items if item]

# Apply sorting
if desc:
items = list(reversed(items))

# Apply pagination
sliced_items = items[offset : (offset + limit) if limit is not None else total]

# Apply skip_empty filter if requested
if skip_empty:
sliced_items = [item for item in sliced_items if item]

await self._update_metadata(update_accessed_at=True)

return DatasetItemsListPage(
Expand Down
Loading