Skip to content

test: isolate config sync e2e resources#14

Merged
guoqqqi merged 1 commit intomasterfrom
codex/e2e-shared-env-isolation
Apr 29, 2026
Merged

test: isolate config sync e2e resources#14
guoqqqi merged 1 commit intomasterfrom
codex/e2e-shared-env-isolation

Conversation

@guoqqqi
Copy link
Copy Markdown
Contributor

@guoqqqi guoqqqi commented Apr 29, 2026

Summary

  • use unique resource IDs in config sync E2E tests so parallel PR runs do not delete each other's resources in the shared API7 environment
  • skip repeated context validation during per-test setup because TestMain already verifies control-plane health and resolves the gateway group
  • include context creation stdout/stderr in failure output for faster diagnosis

Verification

  • go test ./...
  • go test -c -tags=e2e -o /tmp/a7-e2e.test ./test/e2e
  • git diff --check

Copilot AI review requested due to automatic review settings April 29, 2026 14:55
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

Warning

Rate limit exceeded

@guoqqqi has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 58 minutes and 44 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 13d6ddc7-e90a-4b11-a9db-c98a938a27a0

📥 Commits

Reviewing files that changed from the base of the PR and between 024dacd and 6669200.

📒 Files selected for processing (2)
  • test/e2e/config_sync_test.go
  • test/e2e/setup_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/e2e-shared-env-isolation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 58 minutes and 44 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves robustness of config sync E2E tests when multiple CI jobs run against the same shared API7 EE environment, by avoiding resource ID collisions and reducing repeated context validation overhead during test setup.

Changes:

  • Generate per-test unique service/route IDs in config sync E2E tests to prevent cross-run deletions.
  • Add --skip-validation to per-test context creation to avoid redundant health checks already performed in TestMain.
  • Include context creation stdout/stderr in failures to speed up debugging.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test/e2e/setup_test.go Adds unique ID helper + counter; skips context validation during per-test setup; improves failure diagnostics.
test/e2e/config_sync_test.go Switches hardcoded service/route IDs to unique per-test IDs in config sync tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@guoqqqi guoqqqi merged commit 76d9d15 into master Apr 29, 2026
10 checks passed
@guoqqqi guoqqqi deleted the codex/e2e-shared-env-isolation branch April 29, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants