reject non-ascii digits when lexing xsd integer types#32
Open
aizu-m wants to merge 2 commits into
Open
Conversation
Member
|
can you add tests? |
Author
|
Added XsTypeConverterTest covering lexInt/lexShort/lexByte. It checks ascii still parses and that fullwidth, arabic-indic and devanagari digits now throw NumberFormatException. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed while feeding random unicode into lexInt: parseIntXsdNumber uses Character.digit(c, 10), which maps any unicode decimal digit (fullwidth U+FF11, arabic-indic U+0661, devanagari, ...) to a value, so "１２３" parses to 123 as a valid xsd:int/short/byte. Those code points are outside the xsd lexical space and lexLong/lexInteger already reject them via Long.parseLong/BigInteger. Restrict the digit check to ascii 0-9.