Skip to content

build: introduce aggregator modules and unify pom display names#8541

Open
rzo1 wants to merge 2 commits intomasterfrom
pom-modules-review
Open

build: introduce aggregator modules and unify pom display names#8541
rzo1 wants to merge 2 commits intomasterfrom
pom-modules-review

Conversation

@rzo1
Copy link
Copy Markdown
Contributor

@rzo1 rzo1 commented Apr 28, 2026

The storm-multilang/, storm-dist/, external/ and examples/ trees previously listed their children directly in the root pom (or its profiles) without an aggregator pom of their own, which broke the standard Maven multi-module shape (no mvn -pl <group> -am builds, no shared parent for grouped concerns) and made the root module list noisy. Pom display names were also inconsistent or missing across the tree.

  • Add aggregator poms: storm-multilang/pom.xml (storm-multilang), storm-dist/pom.xml (storm-dist), external/pom.xml (storm-external), examples/pom.xml (storm-examples). All four use packaging=pom and inherit from the storm root.
  • Repoint each child under those trees to its new aggregator parent (relativePath ../pom.xml). storm-dist/binary and storm-dist/source likewise declare storm-dist as parent. Children's own artifactId/groupId are not changed.
  • Collapse the root pom and the dist/externals/examples profiles to one entry per group (storm-multilang, storm-dist, external, examples). Profile activation semantics are preserved (externals and examples remain activeByDefault).
  • Normalize across every pom to "Storm " (e.g. "Storm Client", "Storm Flux Core", "Storm Multilang JavaScript", "Storm Kafka Client", "Storm Starter"). Removes the mix of artifact-style lowercase names, "Apache Storm - X", developer-name false positives in poms with no project , and the few duplicates that crept in.
  • drop duplicate version property declarations in root pom

rzo1 added 2 commits April 28, 2026 11:45
The storm-multilang/, storm-dist/, external/ and examples/ trees previously
listed their children directly in the root pom (or its profiles) without an
aggregator pom of their own, which broke the standard Maven multi-module
shape (no `mvn -pl <group> -am` builds, no shared parent for grouped concerns)
and made the root module list noisy. Pom display names were also inconsistent
or missing across the tree.

- Add aggregator poms: storm-multilang/pom.xml (storm-multilang),
  storm-dist/pom.xml (storm-dist), external/pom.xml (storm-external),
  examples/pom.xml (storm-examples). All four use packaging=pom and inherit
  from the storm root.
- Repoint each child under those trees to its new aggregator parent
  (relativePath ../pom.xml). storm-dist/binary and storm-dist/source likewise
  declare storm-dist as parent. Children's own artifactId/groupId are not
  changed.
- Collapse the root pom <modules> and the dist/externals/examples profiles
  to one entry per group (storm-multilang, storm-dist, external, examples).
  Profile activation semantics are preserved (externals and examples remain
  activeByDefault).
- Normalize <name> across every pom to "Storm <Module>" (e.g. "Storm Client",
  "Storm Flux Core", "Storm Multilang JavaScript", "Storm Kafka Client",
  "Storm Starter"). Removes the mix of artifact-style lowercase names,
  "Apache Storm - X", developer-name false positives in poms with no project
  <name>, and the few duplicates that crept in.
The top-level <properties> block had four keys defined twice. Maven keeps
the last definition, so behavior was already determined; this commit just
removes the dead earlier entries to make the resolved versions explicit.

- netty-tcnative.version: drop 2.0.74.Final, keep 2.0.75.Final
- jedis.version: drop 7.3.0, keep 7.4.1
- netty.version: drop redundant duplicate (both were 4.2.12.Final)
- activemq.version: drop redundant duplicate (both were 6.2.4)
@rzo1 rzo1 requested review from jnioche and reiabreu April 28, 2026 09:47
@rzo1 rzo1 added this to the 3.0.0 milestone Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants