build: replace storm-maven-plugins with git-commit-id-maven-plugin#8540
Open
build: replace storm-maven-plugins with git-commit-id-maven-plugin#8540
Conversation
The custom version-info Mojo in storm-buildtools/storm-maven-plugins only
populated SCM commit/branch/uri, build time and a source MD5 used to filter
storm-{client,core}-version-info.properties at build time. All of that is
covered by io.github.git-commit-id:git-commit-id-maven-plugin (commit, branch)
plus the plugin's own build timestamp, so the bespoke module is no longer
needed.
- Drop storm-buildtools/ tree (storm-maven-plugins module + leftover empty
maven-shade-clojure-transformer dir from the Clojure removal).
- Remove the storm-buildtools/storm-maven-plugins module from the root pom.
- Manage git-commit-id-maven-plugin 9.0.1 in the parent pluginManagement.
- Wire it into storm-client and storm-core in the initialize phase.
- Update version-info templates to reference git.commit.id, git.branch and
git.build.time. Drop srcChecksum from the templates (runtime VersionInfo
already returns "Unknown" when the property is absent, preserving the
IVersionInfo API and REST cluster-summary shape).
jnioche
approved these changes
Apr 28, 2026
reiabreu
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The custom version-info Mojo in storm-buildtools/storm-maven-plugins only populated SCM commit/branch/uri, build time and a source MD5 used to filter storm-{client,core}-version-info.properties at build time. All of that is covered by io.github.git-commit-id:git-commit-id-maven-plugin (commit, branch) plus the plugin's own build timestamp, so the bespoke module is no longer needed.