[SPARK-57721][SQL] Fix LowLatencyMemoryStream package to match its directory#56817
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
[SPARK-57721][SQL] Fix LowLatencyMemoryStream package to match its directory#56817dongjoon-hyun wants to merge 1 commit into
LowLatencyMemoryStream package to match its directory#56817dongjoon-hyun wants to merge 1 commit into
Conversation
Member
Author
|
cc @jerrypeng , @viirya |
viirya
approved these changes
Jun 26, 2026
Member
Author
|
Thank you again, @viirya ! |
dongjoon-hyun
added a commit
that referenced
this pull request
Jun 26, 2026
…directory ### What changes were proposed in this pull request? `LowLatencyMemoryStream.scala` lives in the `.../streaming/sources/` directory but declared `package ...streaming`. This PR changes its package to `...streaming.sources` to match the directory. ### Why are the changes needed? Like the other classes in `sources` directory, we must use a correct package name. https://github.com/apache/spark/blob/08bf0e75e4a07633a69c615e1cb4cd9f317d6bee/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/LowLatencyMemoryStream.scala#L66 This was introduced at Apache Spark 4.1.0 via the following. - #52502 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 4.8 Closes #56817 from dongjoon-hyun/SPARK-57721. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 45b8b96) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Jun 26, 2026
…directory ### What changes were proposed in this pull request? `LowLatencyMemoryStream.scala` lives in the `.../streaming/sources/` directory but declared `package ...streaming`. This PR changes its package to `...streaming.sources` to match the directory. ### Why are the changes needed? Like the other classes in `sources` directory, we must use a correct package name. https://github.com/apache/spark/blob/08bf0e75e4a07633a69c615e1cb4cd9f317d6bee/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/LowLatencyMemoryStream.scala#L66 This was introduced at Apache Spark 4.1.0 via the following. - #52502 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 4.8 Closes #56817 from dongjoon-hyun/SPARK-57721. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 45b8b96) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Jun 26, 2026
…directory `LowLatencyMemoryStream.scala` lives in the `.../streaming/sources/` directory but declared `package ...streaming`. This PR changes its package to `...streaming.sources` to match the directory. Like the other classes in `sources` directory, we must use a correct package name. https://github.com/apache/spark/blob/08bf0e75e4a07633a69c615e1cb4cd9f317d6bee/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/LowLatencyMemoryStream.scala#L66 This was introduced at Apache Spark 4.1.0 via the following. - #52502 No. Pass the CIs. Generated-by: Claude Opus 4.8 Closes #56817 from dongjoon-hyun/SPARK-57721. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 45b8b96) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
Author
|
Merged to master/4.x/4.2/4.1. |
Member
|
Good catch! Thanks @dongjoon-hyun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
LowLatencyMemoryStream.scalalives in the.../streaming/sources/directory but declaredpackage ...streaming. This PR changes its package to...streaming.sourcesto match the directory.Why are the changes needed?
Like the other classes in
sourcesdirectory, we must use a correct package name.spark/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/LowLatencyMemoryStream.scala
Line 66 in 08bf0e7
This was introduced at Apache Spark 4.1.0 via the following.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.8