[SPARK-57693][BUILD] Simplify k8s-client deps management by using BOM#56774
Open
gillespeiffer-db wants to merge 1 commit into
Open
[SPARK-57693][BUILD] Simplify k8s-client deps management by using BOM#56774gillespeiffer-db wants to merge 1 commit into
gillespeiffer-db wants to merge 1 commit into
Conversation
Import the `io.fabric8:kubernetes-client-bom` Bill of Materials in the root
`pom.xml` `<dependencyManagement>` section (at the existing
`${kubernetes-client.version}`) and drop the now-redundant
`<version>${kubernetes-client.version}</version>` pins from the five
`io.fabric8` dependency declarations in the Kubernetes resource-manager modules
(`kubernetes-client`, `volcano-client`, and `volcano-model`).
Mirror the BOM in `project/SparkBuild.scala`, the same way the existing
`jackson-bom` and `grpc-bom` imports are handled, because sbt-pom-reader does
not process import-scope BOMs.
This collapses five individually-pinned version references into a single BOM
import and keeps every Fabric8 artifact aligned to one coherent version set,
following the pattern already used for `jackson-bom`, `jjwt-bom`, and
`grpc-bom`. It is a no-op: the BOM manages `kubernetes-client`,
`volcano-client`, and `volcano-model` at the same version that was pinned
before, so the resolved versions are unchanged.
uros-b
approved these changes
Jun 25, 2026
uros-b
left a comment
uros-b
left a comment
Member
There was a problem hiding this comment.
Thank you @gillespeiffer-db - looks like a clean, mechanical BOM consolidation following the merged grpc/jackson-bom patterns. @dongjoon-hyun @panbingkun PTAL ^^
dongjoon-hyun
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR uses
io.fabric8:kubernetes-client-bomto manageio.fabric8artifact versions, replacing the per-artifact<version>${kubernetes-client.version}</version>declarations acrossresource-managers/kubernetes/coreandresource-managers/kubernetes/integration-tests(kubernetes-client,volcano-client,volcano-model). The BOM is mirrored inproject/SparkBuild.scala(sbt-pom-reader does not process import-scope BOMs). Mirrors the existingjackson-bom(#52668),jjwt-bom(#56155), andgrpc-bom(#56741) imports.Why are the changes needed?
Simplify dependency management.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs. No-op on dependency resolution —
io.fabric8resolves identically (7.7.0, direct and transitive) before/after, verified withbuild/mvn help:effective-pomandbuild/mvn dependency:tree.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)