[ISSUE #10591] Fix IPv6 NPE in NetworkUtil.string2SocketAddress by stripping brackets

[itxaiohanglover]

Which Issue(s) This PR Fixes

Fixes #10591

Brief Description

When a gRPC client connects to the Proxy via IPv6, the remote address is formatted as [240e:...:2]:44880 (with brackets). The NetworkUtil.string2SocketAddress method splits on the last : to separate host and port, but the host part retains the surrounding [] brackets.

When new InetSocketAddress("[240e:...:2]", port) is constructed with a bracketed host, Java's InetAddress.getByName() fails to resolve it, causing getAddress() to return null. This null propagates to CommitLog.asyncPutMessage (line 994) where bornSocketAddress.getAddress() triggers a NullPointerException.

Root cause: string2SocketAddress does not strip IPv6 brackets before constructing InetSocketAddress.

Fix: Strip surrounding [] from the host part before calling new InetSocketAddress(host, port).

How Did You Test This Change?

Added NetworkUtilTest with 5 test cases:

• testString2SocketAddressIPv4 — existing IPv4 behavior unchanged
• testString2SocketAddressIPv6WithBrackets — reproduces the issue: [240e:341:6246:c700:c4ad:e645:459e:2]:44880 now resolves correctly with non-null getAddress()
• testString2SocketAddressIPv6Loopback — [::1]:8080 resolves correctly
• testSocketAddress2StringIPv4 — round-trip conversion unchanged
• testNormalizeAndDenormalizeHostAddress — bracket normalize/denormalize helpers

mvn -pl common -Dtest=NetworkUtilTest test
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
BUILD SUCCESS

[yx9o]

Thanks for the fix. Could you also check SimpleChannel#parseSocketAddress? It currently uses address.split(":"), so [IPv6]:port returns null there. That seems closer to the bornSocketAddress is null NPE in #10591.

[itxaiohanglover]

Thanks for pointing that out! You're right — SimpleChannel#parseSocketAddress used address.split(":"), which produces more than 2 segments for IPv6 addresses like [240e:...:2]:44880, so it returns null and bornSocketAddress ends up null.

Fixed in the latest push — switched to lastIndexOf(":") to split host:port and strip brackets from IPv6 host, consistent with the NetworkUtil.string2SocketAddress fix.

[yx9o]

Thanks for the update. It would be better to add a unit test for the SimpleChannel change.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.17%. Comparing base (8242c1e) to head (a1f5707).

Files with missing lines	Patch %	Lines
.../rocketmq/proxy/service/channel/SimpleChannel.java	50.00%	2 Missing and 2 partials ⚠️
.../org/apache/rocketmq/common/utils/NetworkUtil.java	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #10592      +/-   ##
=============================================
- Coverage      48.26%   48.17%   -0.10%     
+ Complexity     13433    13410      -23     
=============================================
  Files           1378     1378              
  Lines         100817   100823       +6     
  Branches       13040    13042       +2     
=============================================
- Hits           48660    48569      -91     
- Misses         46211    46295      +84     
- Partials        5946     5959      +13     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.