Optimize getEntry performance in ZipInputStreamZipEntrySource using O(1) case-insensitive lookups#1144
Merged
pjfanning merged 1 commit intoJun 15, 2026
Conversation
…rce and eliminates an unnecessary O(N) fallback scan
877b040 to
3921bce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entry names are normalized and lowercased before being stored in the zipEntries map:
name = IOUtils.normalizePath(name).toLowerCase(Locale.ROOT);
However, getEntry() performs its initial lookup using a non-lowercased key:
final ZipArchiveEntry ze = zipEntries.get(normalizedPath);
As a result, lookups for mixed-case paths may miss the direct map lookup and fall back to a linear case-insensitive scan of all entries, degrading lookup performance from O(1) to O(N).
Solution
Apply the same normalization strategy during lookup:
return zipEntries.get(normalizedPath.toLowerCase(Locale.ROOT));
This makes lookup behavior consistent with key storage, restores O(1) retrieval, and removes the need for the fallback linear scan.