PHOENIX-7842 Reduce the shading contribution to build time#2460
Open
apurtell wants to merge 3 commits intoapache:masterfrom
Open
PHOENIX-7842 Reduce the shading contribution to build time#2460apurtell wants to merge 3 commits intoapache:masterfrom
apurtell wants to merge 3 commits intoapache:masterfrom
Conversation
…one. They don't contribute significantly to build time.
richardantal
approved these changes
May 6, 2026
Contributor
richardantal
left a comment
richardantal
left a comment
There was a problem hiding this comment.
LGTM
Its always nice to have a faster build time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phoenix's build time is dominated by four sibling shade executions (
phoenix-client-embedded,phoenix-client-lite,phoenix-server,phoenix-mapreduce-byo-shaded-hbase). This change upgradesmaven-shade-pluginto 3.6.2, which declares thread safety and fixes bugs, somvn -T 1Cparallelizes the four shades and they complete successfully, and turns off source-jar shading by default and reenables it under-Prelease.It also makes
phoenix-mapreduce-byo-shaded-hbaserelease-only. The module is moved out of theshade-and-assembly profileand into-Prelease, andphoenix-assemblyis refactored so the mapreduce dependency is only pulled in only under-Prelease.BUILDING.mddocuments the new fast paths.Verified end-to-end.
mvn -T 1C clean packagebuilds 15 modules with no mapreduce jar in the tarballmvn -T 1C -Prelease clean packagebuilds all 16 with the mapreduce uberjar bundled.The build time is reduced from 26:37 to 11:27 on my M4 MacBook, a 2.32x speedup.