Skip to content

one-time array sanity check for use with OperatorProcessor#38

Closed
skjolber wants to merge 6235 commits intoapache:trunkfrom
skjolber:optimization_validator
Closed

one-time array sanity check for use with OperatorProcessor#38
skjolber wants to merge 6235 commits intoapache:trunkfrom
skjolber:optimization_validator

Conversation

@skjolber
Copy link
Copy Markdown

@skjolber skjolber commented Jul 1, 2017

Input for #27 (PR not indented for merge). The unit tests seem to work fine with the one-time array. This approach has the limitation that it relies on test coverage.

Manual inspection seems to verify that the passed array is not saved, however some ArrayList.sublist(..) calls exist; in the arraylist implementation these relay on the parent array. However these are not kept either.

THausherr and others added 30 commits March 31, 2017 17:22
@THausherr
PDFBOX-2852: use JDK7 syntax
27771ee 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1789716 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-2852: sonar fix
5a72289 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1789788 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-3742: assume that valid non-blank sequence after EI is Q or EMC
da4c66c 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1789868 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-3740: don't get standard 14 AFM if font is embedded
6dea20b 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1789889 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-3743: javadoc and comment explaining that signatureOptions sho…
b0d4afa 
…uld not go out of scope before saving is finished

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1790138 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-3741: check default colorspace + test case
3483c99 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1790143 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-2852: simplify code
f29122a 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1790144 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-2852: sonar fix
441e300 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1790147 13f79535-47bb-0310-9956-ffa450edef68
@lehmi
PDFBOX-3747: sort code mappings to provide a reliable order
f66cc1e 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1790427 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-3745: use 0 default of /MissingWidth, take space width from fo…
c45699f 
…nt if 0, update test result files

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1790428 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-3747: added test, cleaned existing code, use junit 4 style, us…
dd7bb03 
…e JDK7

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1790574 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-3748: don't throw UnsupportedOperationException for wrong vers…
e4bb199 
…ion, just skip

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1790580 13f79535-47bb-0310-9956-ffa450edef68
@lehmi
PDFBOX-2852: move code to be called once out of iteration loop
21d48b1 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1790745 13f79535-47bb-0310-9956-ffa450edef68
@lehmi
PDFBOX-2852: simplify code, use switch, fix copy&paste issue
d63716c 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1790758 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-2852: use JDK7 syntax, fix javadoc
fbc970e 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1790885 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-2852: remove unused method, use JDK7 syntax
cd5c477 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1790895 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-2852: use JDK7 syntax, don't use default charset
3f25940 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1791004 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-2852: use JDK7 syntax
fe85cff 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1791011 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-2852: use JDK7 syntax
1d40054 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1791014 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-2852: use JDK7 syntax
8d53062 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1791017 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-2852: fix imports
1bee23d 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1791018 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-2852: use JDK7 syntax
352fb0b 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1791020 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-3754: parse empty dictionary
6b9ec9d 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1791157 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-2852: use JDK7 syntax
465bf32 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1791170 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-3755: skip operators with non number parameters
b4c3deb 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1791208 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-3755: organize imports
5e99dfb 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1791210 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-3750: be lenient when ToUnicode cmap is bad
f449290 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1791272 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-2852: use JDK7 syntax
b931e09 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1791301 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-2852: use JDK7 syntax
431fb3c 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1791319 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-2852: use JDK7 syntax
9ef5848 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1791320 13f79535-47bb-0310-9956-ffa450edef68
THausherr and others added 24 commits June 17, 2017 06:37
@THausherr
PDFBOX-2852: refactor
76ebed1 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1798993 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-3515: accept a Type 1-Equivalent CFF font too, as suggested by…
7737e38 
… Esteban Nicolas Ruiz

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1798995 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-3515: refactor
2b48463 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1799006 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-2852: improve message
7880ca6 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1799078 13f79535-47bb-0310-9956-ffa450edef68
@lehmi
PDFBOX-3536: provide another unread method for byte arrays to avoid a…
2a0f086 
…rray copies

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1799083 13f79535-47bb-0310-9956-ffa450edef68
@lehmi
PDFBOX-3536: improve the end of COSString detection for unbalanced pa…
ff09496 
…renthesis, some small optimizations

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1799084 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-2852: use switch
06bb6f7 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1799233 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-2852: use jdk7 syntax
1a5f3a5 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1799237 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-2852: use jdk7 syntax
d8ddae5 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1799238 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-2852: use jdk7 syntax
2f8aaaa 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1799239 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-2852: use jdk7 syntax
5c8f3ed 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1799240 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-2852: refactor
c1f8852 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1799282 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-3833: don't treat prolonged sound mark as a diacritic
44f123e 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1799390 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-3833: add test case
1c3bcc5 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1799483 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-3836: lastClip needs to be reset, because after intersection i…
21a1c4e 
…t is still the same object

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1799592 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-3838: avoid NPE
f88b7a0 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1799595 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-3839: avoid AIOOB
cefd92e 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1799596 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-2852: make field final
0547a29 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1799758 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-2852: use switch
571c19c 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1799760 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-3820: add constructor for signing existing signature fields, a…
daabc46 
…s suggested by Lonzak

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1799763 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-3820: add methods for signing existing signature fields, as su…
5c1d596 
…ggested by Lonzak

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1799765 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-3832: add example of form with embedded font
f6b1a03 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1799976 13f79535-47bb-0310-9956-ffa450edef68
@THausherr
PDFBOX-2852: Sonar fix
60ec358 
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1800081 13f79535-47bb-0310-9956-ffa450edef68
@skjolber
one-time array sanity check for use with OperatorProcessor
2fe6bce
@skjolber skjolber mentioned this pull request Jul 1, 2017
Open
@skjolber
Copy link
Copy Markdown
Author

skjolber commented Jul 1, 2017

Build is broken in jdk 7, works in jdk 8 - which is okey.

@skjolber
Copy link
Copy Markdown
Author

skjolber commented Mar 15, 2018

Bump

@asfgit asfgit closed this in 2648bb1 May 23, 2020
bsanchezb pushed a commit to bsanchezb/pdfbox that referenced this pull request May 29, 2020
@lehmi @bsanchezb
closes #2, closes apache#4, closes apache#5, closes apache#60, closes a…
ad35099 
…pache#74, closes apache#6, closes apache#7, closes apache#8, closes apache#23, closes apache#24, closes apache#35, closes apache#36, closes apache#38, closes apache#41: empty commit to close rejected, abandoned and completed PRs

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1878054 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@skjolber @THausherr @lehmi @tballison