[core] Add file_name and clustering_columns fields to files system table#7667
Open
heye1005 wants to merge 1 commit intoapache:masterfrom
Open
[core] Add file_name and clustering_columns fields to files system table#7667heye1005 wants to merge 1 commit intoapache:masterfrom
heye1005 wants to merge 1 commit intoapache:masterfrom
Conversation
2 tasks
37cf0e4 to
f066dcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #7283.
Added
file_nameandclustering_columnsto the$filessystem table.file_name: just the file name, without the path prefixclustering_columns: the clustering columns from table schema options, comma-separated. NULL if not configured.the issue title says "clustering column and file name system table" — not sure if the intent was a standalone
$clustering_columnstable or just adding fields to an existing one. I went with adding them to$filessince it's only two fields and didn't feel like it warranted a separate table. Happy to change if a standalone table is preferred.Tests
FilesTableTestexpected results to include the new fieldstestFileNameAndClusteringColumns: creates a table withclustering.columnsset, verifies both fieldstestClusteringColumnsNull: verifies the field is NULL when clustering is not configured