[python] Push down IndexedSplit row ranges to Lance reader#7666
Open
chenghuichen wants to merge 3 commits intoapache:masterfrom
Open
[python] Push down IndexedSplit row ranges to Lance reader#7666chenghuichen wants to merge 3 commits intoapache:masterfrom
chenghuichen wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
|
+1 |
chenghuichen
changed the title
chenghuichen
changed the title
chenghuichen
changed the title
chenghuichen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
After a global index search returns a sparse set of matching row IDs, the data fetch path previously used RowIdFilterRecordBatchReader for Lance — reading the entire Lance file and discarding non-matching rows in memory.
This change converts the global row ID ranges to local file offsets and pushes them down to lance.file.LanceFileReader.take_rows(), so only the matched rows are physically read from disk, leveraging Lance's native random-access capability.
Tests