test(python): Add tests for python sdk#3432
Conversation
|
Thanks for the PR. It is labeled Slash commands (own line, regular comment) move it around the queue:
See CONTRIBUTING.md for details. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3432 +/- ##
============================================
+ Coverage 74.57% 74.60% +0.03%
Complexity 937 937
============================================
Files 1249 1248 -1
Lines 123564 123576 +12
Branches 99837 99840 +3
============================================
+ Hits 92143 92190 +47
+ Misses 28438 28401 -37
- Partials 2983 2985 +2
🚀 New features to boost your workflow:
|
hubcio
left a comment
There was a problem hiding this comment.
a couple notes that don't land on lines this PR changed, so leaving them here:
consume_messages in src/consumer.rs still has four unwrap() calls (around lines 170, 192, 207, 213) that this PR didn't touch. the call_method0("wait").unwrap() plus the join-handle unwrap() form a reachable panic path - if the passed shutdown event object's wait isn't callable it panics across the FFI boundary instead of raising a clean TypeError, since pyo3 doesn't enforce the asyncio.Event | None stub annotation. so the description's "removed all usage of unwrap in the rust code" isn't quite right - client.rs, identifier.rs and send_message.rs are clean now, but consumer.rs isn't. either map these too or soften the claim.
|
Also removed the remaining unwraps from consumer.rs |
|
/ready |
Which issue does this PR address?
Closes #3317
Relates to #
Rationale
The python sdk only had a few happy path tests. This PR adds extensive testing for the sdk. Also explicitly maps errors, replacing unwraps.
What changed?
Local Execution
AI Usage
If AI tools were used, please answer: