HBASE-30125 Rewrite TestHFileBlockHeaderCorruption#8165
Merged
Apache9 merged 1 commit intoapache:masterfrom Apr 30, 2026
Merged
HBASE-30125 Rewrite TestHFileBlockHeaderCorruption#8165Apache9 merged 1 commit intoapache:masterfrom
Apache9 merged 1 commit intoapache:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
484
to
490
| public boolean hasNext() throws IOException { | ||
| HFileBlock next = iter.nextBlock(); | ||
| SeekableByteChannel channel = hFileTestRule.getRWChannel(); | ||
| if (next != null) { | ||
| java.nio.file.Path p = FileSystems.getDefault().getPath(hfsPath.toString()); | ||
| SeekableByteChannel channel = Files.newByteChannel(p, StandardOpenOption.READ, | ||
| StandardOpenOption.WRITE, StandardOpenOption.DSYNC); | ||
| current = new HFileBlockChannelPosition(channel, next.getOffset()); |
Contributor
Author
There was a problem hiding this comment.
Just copied the old code.
Comment on lines
+487
to
+489
| java.nio.file.Path p = FileSystems.getDefault().getPath(hfsPath.toString()); | ||
| SeekableByteChannel channel = Files.newByteChannel(p, StandardOpenOption.READ, | ||
| StandardOpenOption.WRITE, StandardOpenOption.DSYNC); |
Contributor
Author
There was a problem hiding this comment.
Just copied the old code.
Comment on lines
+91
to
+93
| public void setUp(TestInfo testInfo) throws IOException { | ||
| path = new Path(UTIL.getDataTestDirOnTestFS(), testInfo.getTestMethod().get().getName()); | ||
| hfileCtx = new HFileContextBuilder().withBlockSize(4 * 1024).withHBaseCheckSum(true).build(); |
Contributor
Author
There was a problem hiding this comment.
Follow the old pattern with method name, in our test environment a test method is always present.
liuxiaocs7
approved these changes
Apr 29, 2026
Apache9
added a commit
that referenced
this pull request
Apr 30, 2026
Signed-off-by: Xiao Liu <liuxiaocs@apache.org> (cherry picked from commit 2187ed7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.