GROOVY-12162: Harden and extend bytecode peephole optimization

[daniellansun]

https://issues.apache.org/jira/browse/GROOVY-12162

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite	Current: 58dcf7a	Previous: 86c6648	Ratio
org.apache.groovy.bench.AryBench.java ( {"n":"100"} )	0.015477611489812521 ms/op	0.010068018756442 ms/op	1.54
org.apache.groovy.bench.CalibrationBench.memoryPointerChase	1028.751188529392 us/op	436.7830551645615 us/op	2.36

This comment was automatically generated by workflow using github-action-benchmark.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 67.10526% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.0978%. Comparing base (86c6648) to head (58dcf7a).

Files with missing lines	Patch %	Lines
.../classgen/asm/PeepholeOptimizingMethodVisitor.java	67.9245%	9 Missing and 8 partials ⚠️
...rg/codehaus/groovy/classgen/AsmClassGenerator.java	58.3333%	5 Missing ⚠️
...codehaus/groovy/classgen/asm/WriterController.java	50.0000%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@                Coverage Diff                 @@
##               master      #2707        +/-   ##
==================================================
- Coverage     69.1077%   69.0978%   -0.0100%     
- Complexity      34235      34247        +12     
==================================================
  Files            1537       1538         +1     
  Lines          129356     129379        +23     
  Branches        23503      23514        +11     
==================================================
+ Hits            89395      89398         +3     
- Misses          31941      31953        +12     
- Partials         8020       8028         +8     

Files with missing lines	Coverage Δ
...g/codehaus/groovy/classgen/asm/CallSiteWriter.java	85.5769% <100.0000%> (-0.1374%)	⬇️
...y/classgen/asm/PeepholeOptimizingClassVisitor.java	100.0000% <100.0000%> (ø)
...codehaus/groovy/classgen/asm/WriterController.java	86.1111% <50.0000%> (-1.1229%)	⬇️
...rg/codehaus/groovy/classgen/AsmClassGenerator.java	85.0399% <58.3333%> (-0.0217%)	⬇️
.../classgen/asm/PeepholeOptimizingMethodVisitor.java	90.8861% <67.9245%> (-3.7663%)	⬇️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud]

Quality Gate failed

Failed conditions
76.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

[github-actions]

JMH summary — classic (commit d2fd62f)

Speedup vs trailing 90-day baseline on gh-pages. Higher = faster.
1.00 = in line with history. Per-benchmark ratio, geomean within group.
Time-per-op units inverted so direction is consistent. The calibrated
column divides out this runner's speed vs the baseline hardware, as
measured by Groovy-independent pure-Java ruler benchmarks.

Group	Speedup	Calibrated	n
bench	0.990 ×	0.982 ×	84
core	1.023 ×	1.031 ×	77
grails	0.988 ×	1.013 ×	80

_{Runner calibration (this run vs baseline hardware): bench 1.00× (26 rulers) · core-ag 0.98× (3 rulers) · core-hz 1.01× (3 rulers) · grails-ad 0.96× (3 rulers) · grails-ez 0.99× (3 rulers)}

_{Baseline: dev/bench/jmh/<part>/classic/data.js on gh-pages, trailing 90 days. Daily dashboard · Per-suite raw data}

[github-actions]

JMH summary — indy (commit d2fd62f)

Speedup vs trailing 90-day baseline on gh-pages. Higher = faster.
1.00 = in line with history. Per-benchmark ratio, geomean within group.
Time-per-op units inverted so direction is consistent. The calibrated
column divides out this runner's speed vs the baseline hardware, as
measured by Groovy-independent pure-Java ruler benchmarks.

Group	Speedup	Calibrated	n
bench	0.965 ×	0.994 ×	84
core	3.516 ×	3.304 ×	77
grails	2.600 ×	2.354 ×	80

⚠️ Runner speed differs ≥15% from the historical baseline hardware for: grails-ad. Raw speedups are not meaningful for those parts — use the calibrated column.

_{Runner calibration (this run vs baseline hardware): bench 0.97× (26 rulers) · core-ag 1.00× (3 rulers) · core-hz 1.14× (3 rulers) · grails-ad 1.40× (3 rulers) · grails-ez 0.91× (3 rulers)}

_{Baseline: dev/bench/jmh/<part>/indy/data.js on gh-pages, trailing 90 days. Daily dashboard · Per-suite raw data}

[testlens-app]

✅ All tests passed ✅

🏷️ Commit: 58dcf7a
▶️ Tests: 103778 executed
⚪️ Checks: 31/31 completed

---

Learn more about TestLens at testlens.app.