GEP-21: Broadening AST transform awareness under joint compilation (i…#2500
Closed
paulk-asert wants to merge 1 commit intoapache:masterfrom
Closed
GEP-21: Broadening AST transform awareness under joint compilation (i…#2500paulk-asert wants to merge 1 commit intoapache:masterfrom
paulk-asert wants to merge 1 commit intoapache:masterfrom
Conversation
paulk-asert
force-pushed
the
spikeGEP21
branch
2 times, most recently
from
e43b120 to
cf527b4
Compare
blackdrag
reviewed
Apr 29, 2026
| * stub generator emits stubs — see GEP-21). | ||
| */ | ||
| public static org.codehaus.groovy.control.CompilationUnit.IPrimaryClassNodeOperation | ||
| invocationOperation(final CompilePhase phase, final ASTTransformationsContext context) { |
Contributor
There was a problem hiding this comment.
concept wise I am not so happy with using IPrimaryClassNodeOperation here. It is more of an internal interface of CompilationUnit, it should not be used directly outside really.
Contributor
Author
There was a problem hiding this comment.
I have changed this - please check if the new approach seems okay to you. I renamed the branch and it looks like GitHub doesn't let you keep that in the same PR. So please check the other PR.
…nitial spike for Shape C)
Contributor
Author
|
This is now in: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nitial spike for Shape C)