[server] Fix auto partition drop delayed by DAY creation jitter#3174
Open
swuferhong wants to merge 1 commit intoapache:mainfrom
Open
[server] Fix auto partition drop delayed by DAY creation jitter#3174swuferhong wants to merge 1 commit intoapache:mainfrom
swuferhong wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3173
The random delay for DAY partitions (0~23 hours) is designed to spread partition creation load, but was incorrectly passed to dropPartitions(), causing expired partitions to linger up to ~23 hours beyond the retention boundary.
Fix by using the actual current time (now) for dropPartitions() instead
of the jitter-delayed createPartitionInstant.
Brief change log
Tests
API and Format
Documentation