Skip to content

[fix](fe) Forbid adding key columns on sync-MV MOW tables#62875

Open
Hastyshell wants to merge 1 commit intoapache:masterfrom
Hastyshell:fix-doris-22696-sync-mv-key-column
Open

[fix](fe) Forbid adding key columns on sync-MV MOW tables#62875
Hastyshell wants to merge 1 commit intoapache:masterfrom
Hastyshell:fix-doris-22696-sync-mv-key-column

Conversation

@Hastyshell
Copy link
Copy Markdown
Collaborator

Summary

  • reject add key column schema changes on merge-on-write unique tables when a sync materialized view still exists
  • raise a clear remediation error instead of allowing sync MV metadata to become inconsistent after schema change
  • add FE coverage for the guarded sync MV schema change path

Testing

  • Not run locally; FE UT is currently blocked by missing thirdparty/installed/bin/protoc

### What problem does this PR solve?

Issue Number: None

Related PR: None

Problem Summary: Reject add key column schema changes on merge-on-write unique tables that still have sync materialized views, because the alter can leave sync MV metadata inconsistent and cause wrong-result rewrites.

### Release note

Reject unsupported add key column schema changes when sync materialized views exist on merge-on-write unique tables.

### Check List (For Author)

- Test: No need to test (local FE UT is blocked by missing thirdparty/installed/bin/protoc; added FE unit test coverage)
- Behavior changed: Yes (unsupported schema change is now rejected with a clear error)
- Does this need documentation: No
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Hastyshell
Copy link
Copy Markdown
Collaborator Author

run buildall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants