Skip to content

[fix](fe) Preserve replayed light schema job timestamps#62861

Open
Hastyshell wants to merge 1 commit intoapache:masterfrom
Hastyshell:fix-light-schema-replay-job-timestamps
Open

[fix](fe) Preserve replayed light schema job timestamps#62861
Hastyshell wants to merge 1 commit intoapache:masterfrom
Hastyshell:fix-light-schema-replay-job-timestamps

Conversation

@Hastyshell
Copy link
Copy Markdown
Collaborator

Summary

  • persist original createTimeMs and finishedTimeMs in light schema change replay logs for add/drop columns and inverted indexes
  • restore the original timestamps when replaying finished light schema change jobs so alter metadata remains stable after FE restart or failover
  • add serialization coverage for both persisted replay info objects

Testing

  • ./run-fe-ut.sh --run org.apache.doris.persist.TableAddOrDropColumnsInfoTest,org.apache.doris.persist.TableAddOrDropInvertedIndicesInfoTest

### What problem does this PR solve?

Issue Number: None

Related PR: None

Problem Summary: Preserve the original create and finish timestamps for light schema change jobs when FE replays add/drop column and inverted index metadata, so SHOW ALTER metadata stays consistent after restart or failover.

### Release note

Preserve original timestamps for replayed light schema change jobs.

### Check List (For Author)

- Test: FE unit test

    - ./run-fe-ut.sh --run org.apache.doris.persist.TableAddOrDropColumnsInfoTest,org.apache.doris.persist.TableAddOrDropInvertedIndicesInfoTest

- Behavior changed: Yes (replayed light schema change jobs now keep their original timestamps)

- Does this need documentation: No
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Hastyshell
Copy link
Copy Markdown
Collaborator Author

run buildall

@hello-stephen
Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 33.33% (22/66) 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants