test: add explicit negative-count cases for array_repeat#4182
Open
slavlotski wants to merge 1 commit intoapache:mainfrom
Open
test: add explicit negative-count cases for array_repeat#4182slavlotski wants to merge 1 commit intoapache:mainfrom
slavlotski wants to merge 1 commit intoapache:mainfrom
Conversation
Spark treats negative counts as zero in array_repeat, returning an empty array. DataFusion's array_repeat (used by Comet since apache#3516) already matches this: get_count_with_validity clamps c <= 0 to 0. The existing SQL-file test covers a (1, -1) row, but the Scala-level test in CometArrayExpressionSuite did not assert this case. Add two assertions (integer column + string-cast column) so the parity is locked in against future regressions. Closes apache#3176
Author
|
Hi @andygrove. This addresses #3176 by adding explicit negative-count assertions. The runtime behavior was already aligned by #3516 (DataFusion's array_repeat clamps c <= 0 to 0); this just locks in the parity at the Scala test level. Would appreciate a review when you have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spark treats negative counts as zero in array_repeat, returning an empty array. DataFusion's array_repeat (used by Comet since #3516) already matches this: get_count_with_validity clamps c <= 0 to 0.
The existing SQL-file test covers a (1, -1) row, but the Scala-level test in CometArrayExpressionSuite did not assert this case. Add two assertions (integer column + string-cast column) so the parity is locked in against future regressions.
Which issue does this PR close?
Closes #3176
Rationale for this change
What changes are included in this PR?
How are these changes tested?