feat: add poll_now_notify to poll_loop and on_work_available callback#1893
Open
Jeadie wants to merge 2 commits into
Open
feat: add poll_now_notify to poll_loop and on_work_available callback#1893Jeadie wants to merge 2 commits into
poll_now_notify to poll_loop and on_work_available callback#1893Jeadie wants to merge 2 commits into
Conversation
Adds an optional poll_now_notify: Option<Arc<Notify>> parameter to the executor poll_loop so the scheduler can wake an idle executor immediately instead of waiting for the next poll interval. The idle wait becomes a tokio::select! over the poll interval and the notify. Adds an OnWorkAvailableFn callback to SchedulerConfig, invoked from the query stage scheduler when new work becomes available (after JobSubmitted and when new stages become runnable). Ported from #12 for upstreaming.
Jeadie
changed the title
poll_now_notify to poll_loop and on_work_available callback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Closes #.Suggested by @milenkovicm that we should upstream our changes (see comment).Rationale for this change
Useful in spiceai/datafusion-ballista for production features.
What changes are included in this PR?
Adds two related hooks for push-style executor scheduling:
poll_now_notify: Option<Arc<Notify>>parameter on the executorpoll_loop. When provided, the idle wait becomes atokio::select!over the poll interval and the notify, so the scheduler can wake an idle executor immediately instead of waiting for the next poll tick.Nonepreserves the existing timer-only behavior.OnWorkAvailableFncallback onSchedulerConfig(on_work_available), invoked by the query stage scheduler when new work becomes available (afterJobSubmittedand when new stages become runnable).Ported from spiceai#12