feat: add a broadcast channel for job state event notifications#1891
Open
Jeadie wants to merge 2 commits into
Open
feat: add a broadcast channel for job state event notifications#1891Jeadie wants to merge 2 commits into
Jeadie wants to merge 2 commits into
Conversation
Adds a tokio::sync::broadcast Sender to SchedulerServer, subscribable via subscribe_job_updates(). On job state changes (queued/running/completed/ failed/cancelled) the scheduler broadcasts a JobStateEvent carrying the job id and new state. Ported from #15 for upstreaming.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Closes #.Suggested by @milenkovicm that we should upstream our changes (see comment).Rationale for this change
Useful in spiceai/datafusion-ballista for production features.
What changes are included in this PR?
Summary
Adds a
tokio::sync::broadcastsender toSchedulerServer, subscribable viasubscribe_job_updates(). On job state changes (queued / running / completed / failed / cancelled) the scheduler broadcasts aJobStateEventcarrying the job id and new state. Lets components holding a handle to the scheduler observe job lifecycle transitions without polling.Relationship to the existing JobStatusSubscriber
Similar to the existing
JobStatusSubscriber(mpsc) mechanism wired throughsubmit_job(..., subscriber). This broadcast channel is a separate, fan-out style notification path; worth deciding the best DX between these.JobStatusSubscriber(existing)JobStateEventbroadcast (this PR)mpsc- single consumerbroadcast- fan-outExecuteQuery/GetJobStatusResult.subscribe_job_updates()JobStatusJobStateEvent { job_id: String, state }Both fire from the same lifecycle points in
query_stage_scheduler.rs.Ported from spiceai#15.