Fix duplicated TDML exception output and simplify exception handling#1668
Open
gdesrosiers1805 wants to merge 1 commit into
Open
Fix duplicated TDML exception output and simplify exception handling#1668gdesrosiers1805 wants to merge 1 commit into
gdesrosiers1805 wants to merge 1 commit into
Conversation
TDMLException previously embedded cause message text in the outer exception message while also passing the same cause into the Java Exception cause chain. This resulted in duplicate output, where the same error appeared both in the exception message and again in the "Caused by:" section. -Simplified TDMLException to support two construction paths only: one for explicit message strings, and one for wrapping a Throwable. Removed the causes field from the TDMLException trait and use cause from TDMLExceptionImpl constructor parameter. -Also removed the constructor that accepted multiple causes. Callers that previously passed multiple exceptions now aggregate their messages into a single newline-delimited message before constructing the string-based exception. -Additionally updated TDMLRunner to catch XMLDifferenceException directly when calling XMLUtils.compareAndReport, since that method specifically throws XMLDifferenceException. DAFFODIL-3078
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TDMLException previously embedded cause message text in the outer exception message while also passing the same cause into the Java Exception cause chain. This resulted in duplicate output, where the same error appeared both in the exception message and again in the "Caused by:" section.
-Simplified TDMLException to support two construction paths only:
one for explicit message strings, and one for wrapping a Throwable.
Removed the causes field from the TDMLException trait and use cause
from TDMLExceptionImpl constructor parameter.
-Also removed the constructor that accepted multiple causes. Callers
that previously passed multiple exceptions now aggregate their
messages into a single newline-delimited message before constructing
the string-based exception.
-Additionally updated TDMLRunner to catch XMLDifferenceException
directly when calling XMLUtils.compareAndReport, since that method
specifically throws XMLDifferenceException.
DAFFODIL-3078