add lastIndexOfAnyChar method just like indexOfAny#273
Open
qxo wants to merge 2 commits intoapache:masterfrom
Open
add lastIndexOfAnyChar method just like indexOfAny#273qxo wants to merge 2 commits intoapache:masterfrom
qxo wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
|
Thanks for the pull request, but the build fails because of checkstyle violations, see: https://travis-ci.org/apache/commons-lang/jobs/248359934 for details. |
Contributor
|
@PascalSchumacher will it be okay if I will fix warnings for the author? |
Contributor
Contributor
Author
|
ok, I'll check it :) |
garydgregory
requested changes
Jan 12, 2018
Member
garydgregory
left a comment
garydgregory
left a comment
There was a problem hiding this comment.
Thank you for the PR. Please review my comments.
| * @param searchChars the chars to search for, may be null | ||
| * @return the last index of any of the chars, -1 if no match or null input | ||
| */ | ||
| public static int lastIndexOfAnyChar( final CharSequence cs,final char... searchChars) { |
| } | ||
|
|
||
| /** | ||
| * <p>Search a CharSequence to find the last index of any |
Member
There was a problem hiding this comment.
Use the active voice in Javadoc: "Returns...", "Searches...", "Gets..." and so on.
|
|
||
| @Test | ||
| public void testLastIndexOfAny_StringCharArray() { | ||
| assertEquals(-1, StringUtils.lastIndexOfAnyChar(null, (char[]) null)); |
Member
There was a problem hiding this comment.
Maybe use INDEX_NOT_FOUND as a static import instead of -1...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.